From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 18/18] doc: remove devargs deprecation notices
Date: Wed, 13 Dec 2017 10:54:47 +0000 [thread overview]
Message-ID: <VI1PR0401MB246445F4DEF6E22319007FC390350@VI1PR0401MB2464.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20171213102552.nmrf73y7yvzexkz7@bidouze.vm.6wind.com>
Hello Gaetan,
> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, December 13, 2017 3:56 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2 18/18] doc: remove devargs deprecation notices
>
> Hello Shreyansh,
>
> On Wed, Dec 13, 2017 at 03:47:04PM +0530, Shreyansh Jain wrote:
> > Hello Gaetan,
> >
> > On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote:
> > > These actions have been enacted.
> > >
> > > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > > ---
> > > doc/guides/rel_notes/deprecation.rst | 13 -------------
> > > 1 file changed, 13 deletions(-)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > > index ef2264f..23faa19 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -16,19 +16,6 @@ Deprecation Notices
> > > - ``rte_set_log_type``, replaced by ``rte_log_set_level``
> > > - ``rte_get_log_type``, replaced by ``rte_log_get_level``
> > > -* eal: several API and ABI changes are planned for ``rte_devargs`` in
> v17.11.
> > > - The format of device command line parameters will change. The bus will
> need
> > > - to be explicitly stated in the device declaration. The enum
> ``rte_devtype``
> > > - was used to identify a bus and will disappear.
> > > - The structure ``rte_devargs`` will change.
> > > - The ``rte_devargs_list`` will be made private.
> > > - The following functions are deprecated starting from 17.08 and will
> either be
> > > - modified or removed in 17.11:
> > > -
> > > - - ``rte_eal_devargs_add``
> > > - - ``rte_eal_devargs_type_count``
> > > - - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse``
> > > -
> > > * eal: An ABI change is planned for 17.11 to make DPDK aware of IOVA
> address
> > > translation scheme.
> > > Reference to phys address in EAL data-structure or functions may
> change to
> > >
> >
> > Once this patch is formalized, the documentation reference for
> rte_devargs.h
> > also needs to be changed as it still refers to RTE devargs as:
> >
> > "...These devices can be PCI devices or virtual devices....".
> >
> > Similarly, the rte_devargs_parse too has PCI traces.
> >
> > Next step would be to remove the "pci"/"vdev" reference from
> > rte_eal_dev_attach.
> >
>
> Noted, thanks.
>
> > Former can be part of this series, but the later needs to be a separate
> > patch, I think. Let me know if you want me to work on these (or later).
> >
> > Other than that, I think I am OK with overall patch. If you can push the
> > final series (I am not sure it would be with or without bus control), I can
> > give it a spin (to vaildate if non-PCI like FSLMC bus can work fine).
>
> Indeed, I also think everything should be settled first.
> I have mostly finished working on this series yesterday,
> I will integrate your above remarks which will be short.
>
> (Well, by finished I mean I finished the first 90%. The other 90% is
> still in progress...)
>
> I removed the rte_devargs unit test and am not too happy about it. There
> are parsing functions there, which are extremely error-prone and would
> like to have at least the basis for some tests, that we could populate
> as we go. If I have the courage I will try to write it and send it with
> this series.
While reading through the code, I also had the same feeling - there can be corner cases in the parsing functions which I can't imagine. Anyways, those need to be runtime-verified - static reviews may not suffice.
>
> I would certainly appreciate if you are able to fix the pci / vdev
> limitation in rte_eal_dev_attach, as I am starting to be overwhelmed
> with work (trying to finish a lot of things before the holidays).
OK.
Once you give the devargs a push, I will start work on the PCI removal from rte_eal_dev_attach. Before that, I just want to be sure of devargs with non-PCI bus (non hotplug case).
And, thanks for tons of work you are handling. I saw the patches and really appreciate how you have split things up in sequential manner per-patch. It is difficult.
>
> Thanks for the review!
>
> --
> Gaëtan Rivet
> 6WIND
next prev parent reply other threads:[~2017-12-13 10:55 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 16:07 [dpdk-dev] [PATCH 0/6] devargs cleanup Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 1/6] devargs: introduce iterator Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 2/6] devargs: introduce foreach macro Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 3/6] vdev: do not reference devargs_list Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 4/6] bus/pci: " Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 5/6] test: remove rte_devargs unit tests Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 6/6] devargs: make devargs_list private Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 00/18] devargs cleanup Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 01/18] eal: prepend busname on legacy device declaration Gaetan Rivet
2017-12-11 13:57 ` Shreyansh Jain
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 02/18] eal: remove generic devtype Gaetan Rivet
2017-10-17 18:16 ` Aaron Conole
2017-10-18 8:20 ` Gaëtan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 03/18] devargs: introduce iterator Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 04/18] devargs: introduce foreach macro Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 05/18] vdev: do not reference devargs list Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 06/18] bus/pci: " Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 07/18] test: remove devargs unit tests Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 08/18] devargs: make devargs list private Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 09/18] devargs: make parsing variadic Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 10/18] devargs: require bus name prefix Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation Gaetan Rivet
2017-10-16 11:39 ` Shreyansh Jain
2017-10-16 11:42 ` Shreyansh Jain
2017-10-16 13:42 ` Gaëtan Rivet
2017-10-17 5:58 ` Shreyansh Jain
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 12/18] eal: add generic device declaration parameter Gaetan Rivet
2017-12-13 14:26 ` Shreyansh Jain
2017-12-13 14:47 ` Gaëtan Rivet
2017-12-13 15:24 ` Shreyansh Jain
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 13/18] bus: make device recognition function public Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 14/18] net/failsafe: keep legacy sub-device declaration Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 15/18] ether: use new devargs parsing function Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 16/18] devargs: remove old " Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 17/18] devargs: use proper prefix Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 18/18] doc: remove devargs deprecation notices Gaetan Rivet
2017-10-12 11:28 ` Mcnamara, John
2017-12-13 10:17 ` Shreyansh Jain
2017-12-13 10:25 ` Gaëtan Rivet
2017-12-13 10:54 ` Shreyansh Jain [this message]
2017-12-22 4:59 ` Shreyansh Jain
2017-12-22 8:33 ` Gaëtan Rivet
2017-10-17 18:18 ` [dpdk-dev] [PATCH v2 00/18] devargs cleanup Aaron Conole
2017-10-18 8:36 ` Gaëtan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 00/10] " Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 01/10] devargs: introduce iterator Gaetan Rivet
2018-03-21 5:43 ` Tan, Jianfeng
2018-03-21 8:50 ` Gaëtan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 02/10] devargs: introduce foreach macro Gaetan Rivet
2018-04-22 21:42 ` Thomas Monjalon
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 03/10] bus/vdev: do not reference devargs list Gaetan Rivet
2018-03-21 5:41 ` Tan, Jianfeng
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 04/10] bus/pci: " Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 05/10] net/vdev_netvsc: " Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 06/10] test: remove devargs unit tests Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 07/10] devargs: make devargs list private Gaetan Rivet
2018-04-22 21:46 ` Thomas Monjalon
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 08/10] devargs: make parsing variadic Gaetan Rivet
2018-04-22 21:52 ` Thomas Monjalon
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 09/10] devargs: use proper namespace prefix Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 10/10] devargs: rename legacy API Gaetan Rivet
2018-04-22 22:00 ` [dpdk-dev] [PATCH v3 00/10] devargs cleanup Thomas Monjalon
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 " Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 01/10] devargs: introduce iterator Gaetan Rivet
2018-04-23 23:54 ` Stephen Hemminger
2018-04-24 10:22 ` Gaëtan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 02/10] devargs: introduce foreach macro Gaetan Rivet
2018-04-23 23:56 ` Stephen Hemminger
2018-04-24 10:26 ` Gaëtan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 03/10] bus/vdev: do not reference devargs list Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 04/10] bus/pci: " Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 05/10] net/vdev_netvsc: " Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 06/10] test: remove devargs unit tests Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 07/10] devargs: make devargs list private Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 08/10] devargs: make parsing variadic Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 09/10] devargs: use proper namespace prefix Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 10/10] devargs: rename legacy API Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 00/10] devargs cleanup Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 01/10] devargs: introduce iterator Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 02/10] bus/vdev: do not reference devargs list Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 03/10] bus/pci: " Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 04/10] net/vdev_netvsc: " Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 05/10] test: remove devargs unit tests Gaetan Rivet
2018-04-25 0:45 ` Thomas Monjalon
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 06/10] devargs: make devargs list private Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 07/10] devargs: make parsing variadic Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 08/10] devargs: update devargs add documentation Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 09/10] devargs: use proper namespace prefix Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 10/10] devargs: rename legacy API Gaetan Rivet
2018-04-25 1:51 ` Thomas Monjalon
2018-04-25 1:57 ` [dpdk-dev] [PATCH v5 00/10] devargs cleanup Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB246445F4DEF6E22319007FC390350@VI1PR0401MB2464.eurprd04.prod.outlook.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).