From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>,
Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-stable] [PATCH] drivers/crypto/dpaa_sec: update DPAA iova table in dpaa_mem_vtop
Date: Thu, 12 Sep 2019 05:24:23 +0000 [thread overview]
Message-ID: <VI1PR0401MB2541C8BA06631C6A1888967B89B00@VI1PR0401MB2541.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <e708af7d9c4e6a2dcf07767cb4c0b9ecccbd5eb1.1568217211.git.thierry.herbelot@6wind.com>
Hi Thierry,
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Wednesday, September 11, 2019 9:37 PM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>; stable@dpdk.org; Akhil
> Goyal <akhil.goyal@nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: [PATCH] drivers/crypto/dpaa_sec: update DPAA iova table in
> dpaa_mem_vtop
> Importance: High
>
> dpaa_sec needs translations between physical and virtual addresses.
> V to P translation is relatively fast, as memory is managed in contiguous
> segments.
>
> The result of each V to P translation is used to update the DPAA iova table,
> which should be updated by a Mem event callback, but is not.
> Then the DPAA iova table has entries for all needed memory ranges.
>
> With this patch, dpaa_mem_ptov will always use dpaax_iova_table_get_va,
> which ensures optimal performance.
>
> Fixes: 5a7dbb934d75 ('dpaa: enable dpaax library')
> Cc: stable@dpdk.org
> Cc: akhil.goyal@nxp.com
> Cc: hemant.agrawal@nxp.com
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> drivers/crypto/dpaa_sec/dpaa_sec.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c
> b/drivers/crypto/dpaa_sec/dpaa_sec.c
> index 122c80a072ff..22b8b1d63ce0 100644
> --- a/drivers/crypto/dpaa_sec/dpaa_sec.c
> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
> @@ -38,6 +38,7 @@
> #include <rte_dpaa_bus.h>
> #include <dpaa_sec.h>
> #include <dpaa_sec_log.h>
> +#include <dpaax_iova_table.h>
>
> enum rta_sec_era rta_sec_era;
>
> @@ -100,8 +101,10 @@ dpaa_mem_vtop(void *vaddr)
> const struct rte_memseg *ms;
>
> ms = rte_mem_virt2memseg(vaddr, NULL);
> - if (ms)
> + if (ms) {
> + dpaax_iova_table_update(ms->iova, (void *)ms->addr_64,
> ms->len);
[Hemant] This fails 32bit (i686) compilation
You can use "ms->addr" instead of "(void *)ms->addr_64"
> return ms->iova + RTE_PTR_DIFF(vaddr, ms->addr);
> + }
> return (size_t)NULL;
> }
>
> --
> 2.20.1
next prev parent reply other threads:[~2019-09-12 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:06 Thierry Herbelot
2019-09-12 5:24 ` Hemant Agrawal [this message]
2019-09-12 8:38 ` Thierry Herbelot
2019-09-12 8:39 ` Hemant Agrawal
2019-09-19 15:13 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB2541C8BA06631C6A1888967B89B00@VI1PR0401MB2541.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).