From: Akhil Goyal <akhil.goyal@nxp.com>
To: Tejasree Kondoj <ktejasree@marvell.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>
Cc: Anoob Joseph <anoobj@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add feature flag for SSL/TLS order
Date: Mon, 25 Jan 2021 16:36:32 +0000 [thread overview]
Message-ID: <VI1PR04MB316845D9EA9C851B53B2913AE6BD0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210125154757.23654-2-ktejasree@marvell.com>
Hi Tejasree,
> Subject: [PATCH v2 1/3] cryptodev: add feature flag for SSL/TLS order
>
> Added device feature flag for SSL/TLS way of cipher-auth
> operations support i.e. auth generation followed by encryption
> and decryption followed by auth verify so that SSL/TLS tests
> are skipped if the device doesn't support the feature.
>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
Is it something different than
#define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED (1ULL << 19)
/**< Support encrypted-digest operations where digest is appended to data */
@Fan: could you review this patchset.
> doc/guides/cryptodevs/features/default.ini | 1 +
> doc/guides/rel_notes/release_21_02.rst | 7 +++++++
> lib/librte_cryptodev/rte_cryptodev.h | 2 ++
> 3 files changed, 10 insertions(+)
>
> diff --git a/doc/guides/cryptodevs/features/default.ini
> b/doc/guides/cryptodevs/features/default.ini
> index 17b177fc45..cd5f75d8f6 100644
> --- a/doc/guides/cryptodevs/features/default.ini
> +++ b/doc/guides/cryptodevs/features/default.ini
> @@ -31,6 +31,7 @@ CPU crypto =
> Symmetric sessionless =
> Non-Byte aligned data =
> Sym raw data path API =
> +SSL way of chaining =
>
> ;
> ; Supported crypto algorithms of a default crypto driver.
> diff --git a/doc/guides/rel_notes/release_21_02.rst
> b/doc/guides/rel_notes/release_21_02.rst
> index e72a582b1b..45854d5d33 100644
> --- a/doc/guides/rel_notes/release_21_02.rst
> +++ b/doc/guides/rel_notes/release_21_02.rst
> @@ -82,6 +82,13 @@ New Features
> enable applications to add/remove user callbacks which gets called
> for every enqueue/dequeue operation.
>
> +* **Added feature flag in cryptodev library.**
> +
> + Added device feature flag for SSL/TLS way of cipher-auth operations support
> + i.e. auth generation followed by encryption and decryption followed by
> + auth verify in cryptodev library so that SSL/TLS tests are skipped if the
> + device doesn't support the feature.
> +
> * **Updated the OCTEON TX2 crypto PMD.**
>
> * Updated the OCTEON TX2 crypto PMD lookaside protocol offload for IPsec
> with
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index ae34f33f69..6ee3f33c06 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -461,6 +461,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> rte_crypto_asym_xform_type *xform_enum,
> /**< Support operations on data which is not byte aligned */
> #define RTE_CRYPTODEV_FF_SYM_RAW_DP (1ULL << 24)
> /**< Support accelerator specific symmetric raw data-path APIs */
> +#define RTE_CRYPTODEV_FF_SSL_ORDER (1ULL << 25)
> +/**< Support SSL order of cipher-auth xforms chaining */
>
> /**
> * Get the name of a crypto device feature flag
> --
> 2.27.0
next prev parent reply other threads:[~2021-01-25 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 15:47 [dpdk-dev] [PATCH v2 0/3] support SSL/TLS way of cipher-auth operations Tejasree Kondoj
2021-01-25 15:47 ` [dpdk-dev] [PATCH v2 1/3] cryptodev: add feature flag for SSL/TLS order Tejasree Kondoj
2021-01-25 16:36 ` Akhil Goyal [this message]
2021-01-27 12:00 ` Tejasree Kondoj
2021-01-25 15:47 ` [dpdk-dev] [PATCH v2 2/3] common/cpt: add support for SSL/TLS way of cipher-auth operations Tejasree Kondoj
2021-01-25 15:47 ` [dpdk-dev] [PATCH v2 3/3] test/crypto: " Tejasree Kondoj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB316845D9EA9C851B53B2913AE6BD0@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=ktejasree@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).