From: Akhil Goyal <akhil.goyal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"techboard@dpdk.org" <techboard@dpdk.org>,
"anoobj@marvell.com" <anoobj@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
"david.coyle@intel.com" <david.coyle@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to support SDAP
Date: Wed, 14 Oct 2020 20:26:20 +0000 [thread overview]
Message-ID: <VI1PR04MB3168FA4D5D805150D05FA729E6050@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <5343391.ofL17Uz9jy@thomas>
> 12/10/2020 16:10, Akhil Goyal:
> > The SDAP is a protocol in the LTE stack on top of PDCP for
> > QOS. A particular PDCP session may or may not have
> > SDAP enabled. But if it is enabled, SDAP header should be
> > authenticated but not encrypted if both confidentiality and
> > integrity is enabled. Hence, the driver should be intimated
> > from the xform so that it skip the SDAP header while encryption.
> >
> > A new field is added in the PDCP xform to specify SDAP is enabled.
> > The overall size of the xform is not changed, as hfn_ovrd is just
> > a flag and does not need uint32. Hence, it is converted to uint8_t
> > and a 16 bit reserved field is added for future.
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
> > doc/guides/rel_notes/release_20_11.rst | 9 +++++++++
> > lib/librte_security/rte_security.h | 12 ++++++++++--
> > 2 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> > index c34ab5493..fad91487a 100644
> > --- a/doc/guides/rel_notes/release_20_11.rst
> > +++ b/doc/guides/rel_notes/release_20_11.rst
> > @@ -103,6 +103,11 @@ New Features
> > also known as Mount Bryce. See the
> > :doc:`../bbdevs/acc100` BBDEV guide for more details on this new driver.
> >
> > +* **Updated rte_security library to support SDAP.**
> > +
> > + ``rte_security_pdcp_xform`` in ``rte_security`` lib is updated to enable
> > + 5G NR processing of SDAP header in PMDs.
> > +
>
> Please try to keep the ordering:
> crypto and security stuff should be after ethdev drivers
> and related stuff (I would say even after flow-perf).
>
Fixed it while applying the series to dpdk-next-crypto
> > * **Updated Virtio driver.**
> >
> > * Added support for Vhost-vDPA backend to Virtio-user PMD.
> > @@ -307,6 +312,10 @@ API Changes
> > ``rte_fpga_lte_fec_configure`` and structure ``fpga_lte_fec_conf`` to
> > ``rte_fpga_lte_fec_conf``.
> >
> > +* security: ``hfn_ovrd`` field in ``rte_security_pdcp_xform`` is changed from
> > + ``uint32_t`` to ``uint8_t`` so that a new field ``sdap_enabled`` can be added
> > + to support SDAP.
>
> For the API change,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Applied to dpdk-next-crypto
next prev parent reply other threads:[~2020-10-14 20:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 16:06 [dpdk-dev] [PATCH 0/7] support PDCP-SDAP for dpaa2_sec akhil.goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 1/7] common/dpaax/caamflib: Support PDCP-SDAP akhil.goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 2/7] security: modify PDCP xform to support SDAP akhil.goyal
2020-10-05 18:04 ` Coyle, David
2020-10-08 9:01 ` Akhil Goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 3/7] crypto/dpaa2_sec: enable PDCP-SDAP sessions akhil.goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 4/7] crypto/dpaa_sec: " akhil.goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 5/7] test/crypto: Add test vectors for PDCP-SDAP akhil.goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 6/7] test/crypto: Modify test_pdcp_proto to take parameters akhil.goyal
2020-09-03 16:06 ` [dpdk-dev] [PATCH 7/7] test/crypto: Add PDCP-SDAP cases akhil.goyal
2020-10-11 21:33 ` [dpdk-dev] [PATCH v2 0/8] support PDCP-SDAP for dpaa2_sec Akhil Goyal
2020-10-11 21:33 ` [dpdk-dev] [PATCH v2 1/8] common/dpaax/caamflib: Support PDCP-SDAP Akhil Goyal
2020-10-11 21:33 ` [dpdk-dev] [PATCH v2 2/8] security: modify PDCP xform to support SDAP Akhil Goyal
2020-10-11 21:33 ` [dpdk-dev] [PATCH v2 3/8] doc: remove unnecessary API code from security guide Akhil Goyal
2020-10-11 21:33 ` [dpdk-dev] [PATCH v2 4/8] crypto/dpaa2_sec: enable PDCP-SDAP sessions Akhil Goyal
2020-10-11 21:34 ` [dpdk-dev] [PATCH v2 5/8] crypto/dpaa_sec: " Akhil Goyal
2020-10-11 21:34 ` [dpdk-dev] [PATCH v2 6/8] test/crypto: Add test vectors for PDCP-SDAP Akhil Goyal
2020-10-11 21:49 ` Thomas Monjalon
2020-10-12 14:01 ` Akhil Goyal
2020-10-11 21:34 ` [dpdk-dev] [PATCH v2 7/8] test/crypto: Modify test_pdcp_proto to take parameters Akhil Goyal
2020-10-11 21:34 ` [dpdk-dev] [PATCH v2 8/8] test/crypto: Add PDCP-SDAP cases Akhil Goyal
2020-10-12 14:09 ` [dpdk-dev] [PATCH v3 0/8] support PDCP-SDAP for dpaa2_sec Akhil Goyal
2020-10-12 14:09 ` [dpdk-dev] [PATCH v3 1/8] common/dpaax/caamflib: Support PDCP-SDAP Akhil Goyal
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to support SDAP Akhil Goyal
2020-10-14 7:46 ` Thomas Monjalon
2020-10-14 20:26 ` Akhil Goyal [this message]
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 3/8] doc: remove unnecessary API code from security guide Akhil Goyal
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 4/8] crypto/dpaa2_sec: enable PDCP-SDAP sessions Akhil Goyal
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 5/8] crypto/dpaa_sec: " Akhil Goyal
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 6/8] test/crypto: Add test vectors for PDCP-SDAP Akhil Goyal
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 7/8] test/crypto: Modify test_pdcp_proto to take parameters Akhil Goyal
2020-10-12 14:10 ` [dpdk-dev] [PATCH v3 8/8] test/crypto: Add PDCP-SDAP cases Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB3168FA4D5D805150D05FA729E6050@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=david.coyle@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).