From: Nipun Gupta <nipun.gupta@nxp.com>
To: Sunil Kumar Kori <skori@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"marko.kovacevic@intel.com" <marko.kovacevic@intel.com>,
"orika@mellanox.com" <orika@mellanox.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"radu.nicolau@intel.com" <radu.nicolau@intel.com>,
"tomasz.kantecki@intel.com" <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in event mode
Date: Mon, 6 Jan 2020 17:47:05 +0000 [thread overview]
Message-ID: <VI1PR04MB44800C04F8648C4FBA924B80E63C0@VI1PR04MB4480.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CH2PR18MB327037CDDFFDF424084E3786B43C0@CH2PR18MB3270.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Sunil Kumar Kori <skori@marvell.com>
> Sent: Monday, January 6, 2020 11:39 AM
> To: Nipun Gupta <nipun.gupta@nxp.com>; dev@dpdk.org
> Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Akhil Goyal <akhil.goyal@nxp.com>;
> marko.kovacevic@intel.com; orika@mellanox.com;
> bruce.richardson@intel.com; radu.nicolau@intel.com;
> tomasz.kantecki@intel.com
> Subject: RE: [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in
> event mode
>
>
>
> Regards
> Sunil Kumar Kori
>
> >-----Original Message-----
> >From: Nipun Gupta <nipun.gupta@nxp.com>
> >Sent: Monday, January 6, 2020 10:05 AM
> >To: dev@dpdk.org
> >Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> >Kollanukkaran <jerinj@marvell.com>; hemant.agrawal@nxp.com;
> >akhil.goyal@nxp.com; marko.kovacevic@intel.com; orika@mellanox.com;
> >bruce.richardson@intel.com; radu.nicolau@intel.com;
> >tomasz.kantecki@intel.com; Sunil Kumar Kori <skori@marvell.com>; Nipun
> >Gupta <nipun.gupta@nxp.com>
> >Subject: [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in event
> >mode
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> >---
> > examples/l3fwd/l3fwd_event.c | 55 ++++++++++++++++++++++++++++--------
> > examples/l3fwd/l3fwd_event.h | 4 +++
> > examples/l3fwd/main.c | 8 ++++--
> > 3 files changed, 53 insertions(+), 14 deletions(-)
> >
> >diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index
> >68998f42c..ecfaca435 100644
> >--- a/examples/l3fwd/main.c
> >+++ b/examples/l3fwd/main.c
> >@@ -285,7 +285,8 @@ print_usage(const char *prgname)
> > " [--parse-ptype]"
> > " [--per-port-pool]"
> > " [--mode]"
> >- " [--eventq-sched]\n\n"
> >+ " [--eventq-sched]"
> >+ " [--event-eth-queues]\n\n"
> >
> > " -p PORTMASK: Hexadecimal bitmask of ports to
> >configure\n"
> > " -P : Enable promiscuous mode\n"
> >@@ -306,7 +307,10 @@ print_usage(const char *prgname)
> > " --eventq-sched: Event queue synchronization method "
> > " ordered, atomic or parallel.\n\t\t"
> > " Default: atomic\n\t\t"
> >- " Valid only if --mode=eventdev\n\n",
> >+ " Valid only if --mode=eventdev\n"
> >+ " --event-eth-queues: Number of ethernet queues per
> >device.\n\t\t"
> Will it be better to make it like "eth-rx-queues" simply ? So that It will clearly
> reflect that which queues it is referring to, Rx or Tx. Also Comment should be
> updated accordingly.
Agree we should add rx also in the name to make it more clear, but I do not want
to remove event from the name. How about ' --event-eth-rxqs'?
Regards,
Nipun
> >+ " Default: 1\n\t\t"
> >+ " Valid only if --mode=eventdev\n\n",
> > prgname);
> > }
> >
> >--
> >2.17.1
next prev parent reply other threads:[~2020-01-06 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 4:34 [dpdk-dev] [PATCH 1/2] examples/l3fwd: set default schedule type as atomic Nipun Gupta
2020-01-06 4:34 ` [dpdk-dev] [PATCH 2/2] examples/l3fwd: support multiple queues in event mode Nipun Gupta
2020-01-06 6:09 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-01-06 17:47 ` Nipun Gupta [this message]
2020-01-07 12:22 ` [dpdk-dev] [PATCH 1/2 v2] examples/l3fwd: set default schedule type as atomic Nipun Gupta
2020-01-07 12:22 ` [dpdk-dev] [PATCH 2/2 v2] examples/l3fwd: support multiple eth Rx queues in event mode Nipun Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB44800C04F8648C4FBA924B80E63C0@VI1PR04MB4480.eurprd04.prod.outlook.com \
--to=nipun.gupta@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=pbhagavatula@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=skori@marvell.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).