From: Sunil Kumar Kori <sunil.kori@nxp.com>
To: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper
Date: Tue, 3 Jul 2018 06:27:21 +0000 [thread overview]
Message-ID: <VI1PR04MB510470A914FA3B19ADB3A1138F420@VI1PR04MB5104.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <12a1fc10-6879-4e1a-bcb4-ec66a9494346@caviumnetworks.com>
Hello Anoob,
Regards
Sunil Kumar
> -----Original Message-----
> From: Joseph, Anoob [mailto:Anoob.Joseph@caviumnetworks.com]
> Sent: Thursday, June 28, 2018 4:13 PM
> To: Sunil Kumar Kori <sunil.kori@nxp.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; Nikhil Rao
> <nikhil.rao@intel.com>; Pavan Nikhilesh
> <pbhagavatula@caviumnetworks.com>; dev@dpdk.org
> Subject: Re: [PATCH 01/20] eventdev: add files for eventmode helper
>
> Hi Sunil,
>
> On 27-06-2018 11:50, Sunil Kumar Kori wrote:
> > External Email
> >
> > Regards
> > Sunil Kumar
> >
> >> -----Original Message-----
> >> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
> >> Sent: Friday, June 8, 2018 10:54 PM
> >> To: Bruce Richardson <bruce.richardson@intel.com>; Jerin Jacob
> >> <jerin.jacob@caviumnetworks.com>; Pablo de Lara
> >> <pablo.de.lara.guarch@intel.com>
> >> Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>; Hemant Agrawal
> >> <hemant.agrawal@nxp.com>; Narayana Prasad
> >> <narayanaprasad.athreya@caviumnetworks.com>; Nikhil Rao
> >> <nikhil.rao@intel.com>; Pavan Nikhilesh
> >> <pbhagavatula@caviumnetworks.com>; Sunil Kumar Kori
> >> <sunil.kori@nxp.com>; dev@dpdk.org
> >> Subject: [PATCH 01/20] eventdev: add files for eventmode helper
> >>
> >> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> >> ---
> >> lib/librte_eventdev/Makefile | 2 ++
> >> lib/librte_eventdev/rte_eventmode_helper.c | 7 +++++++
> >> lib/librte_eventdev/rte_eventmode_helper.h | 6 ++++++
> >> lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++++++
> >> 4 files changed, 21 insertions(+)
> >> create mode 100644 lib/librte_eventdev/rte_eventmode_helper.c
> >> create mode 100644 lib/librte_eventdev/rte_eventmode_helper.h
> >> create mode 100644
> >> lib/librte_eventdev/rte_eventmode_helper_internal.h
> >>
> > Having a separate helper library to configure eventdev may be a
> > overhead to the application as application needs to understand main DPDK API
> as well as helper routines.
> > It can be kept in application as a separate file.
> For one application we could add a new file, but if we are to enable event mode
> with multiple applications, wouldn't this be duplication of lot of code?
> Considering that I haven't added the required parsing routines, the code
> additions in one application to make it eventdriven would be huge.
>
> I do agree that making this as a library poses its own challenges, but do you have
> something better in mind? Another option we can think of is making all these
> changes part of some common headers and then each application can include
> and start using these functions. I'm fine with any approach, but we need to
> consider making at-least l3fwd & ipsec-secgw also event driven.
>
With this approach, following may be the challenges:
1. Documentation will be required for user to use eventdev helper library.
2. Helper library should cater all the generic use cases which can be catered from rte_eventdev_*** library.
If not, supported configuration/use cases should also be documented and should be future evolving with eventdev library enhancements.
> Thanks,
> Anoob
next prev parent reply other threads:[~2018-07-03 6:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 17:23 [dpdk-dev] [PATCH 00/20] add eventmode helper functions Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper Anoob Joseph
2018-06-27 6:20 ` Sunil Kumar Kori
2018-06-28 10:43 ` Joseph, Anoob
2018-06-28 10:47 ` Ananyev, Konstantin
2018-06-28 10:58 ` Joseph, Anoob
2018-06-28 11:44 ` Ananyev, Konstantin
2018-06-28 11:54 ` Joseph, Anoob
2018-07-03 6:27 ` Sunil Kumar Kori [this message]
2018-07-03 13:13 ` Joseph, Anoob
2018-07-04 10:49 ` Sunil Kumar Kori
2018-06-08 17:24 ` [dpdk-dev] [PATCH 02/20] eventdev: add routines for logging " Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 03/20] eventdev: add eventmode CL options framework Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 04/20] eventdev: allow application to set ethernet portmask Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 05/20] eventdev: add framework for eventmode conf Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 06/20] eventdev: add common initialize routine for eventmode devs Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 07/20] eventdev: add eventdevice init for eventmode Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 08/20] eventdev: add eventdev port-lcore link Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 09/20] eventdev: add option to specify schedule mode for app stage Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 10/20] eventdev: add placeholder for ethdev init Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 11/20] eventdev: add Rx adapter init in eventmode Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 12/20] eventdev: add routine to validate conf Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 13/20] eventdev: add default conf for event devs field in conf Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 14/20] eventdev: add default conf for Rx adapter conf Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 15/20] eventdev: add default conf for event port-lcore link Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 16/20] eventdev: add routines to display the eventmode conf Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 17/20] eventdev: add routine to access eventmode link info Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 18/20] eventdev: add routine to access event queue for eth Tx Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 19/20] eventdev: add routine to launch eventmode workers Anoob Joseph
2018-06-08 17:24 ` [dpdk-dev] [PATCH 20/20] examples/l2fwd: add eventmode for l2fwd Anoob Joseph
2018-06-11 8:32 ` [dpdk-dev] [PATCH 00/20] add eventmode helper functions Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB510470A914FA3B19ADB3A1138F420@VI1PR04MB5104.eurprd04.prod.outlook.com \
--to=sunil.kori@nxp.com \
--cc=Anoob.Joseph@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@caviumnetworks.com \
--cc=nikhil.rao@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).