From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>,
Olivier MATZ <olivier.matz@6wind.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/cmdline: init parse result memeory
Date: Thu, 7 Dec 2017 15:35:24 +0000 [thread overview]
Message-ID: <VI1PR0502MB40795CFEF8A79D18E991BC15AC330@VI1PR0502MB4079.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0502MB40792D118C362C4CECAAFB75AC330@VI1PR0502MB4079.eurprd05.prod.outlook.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xueming(Steven) Li
> Sent: Thursday, December 7, 2017 11:05 PM
> To: Olivier MATZ <olivier.matz@6wind.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib/cmdline: init parse result memeory
>
> Hi Olivier,
>
> > -----Original Message-----
> > From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> > Sent: Thursday, December 7, 2017 10:48 PM
> > To: Xueming(Steven) Li <xuemingl@mellanox.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] lib/cmdline: init parse result memeory
> >
> > On Wed, Nov 15, 2017 at 11:54:02PM +0800, Xueming Li wrote:
> > > Initialize binary result memory before parsing to avoid garbage in
> > > parsing result.
> > >
> > > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> > > ---
> > > lib/librte_cmdline/cmdline_parse.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/lib/librte_cmdline/cmdline_parse.c
> > > b/lib/librte_cmdline/cmdline_parse.c
> > > index 3e12ee54f..9124758f1 100644
> > > --- a/lib/librte_cmdline/cmdline_parse.c
> > > +++ b/lib/librte_cmdline/cmdline_parse.c
> > > @@ -267,6 +267,8 @@ cmdline_parse(struct cmdline *cl, const char * buf)
> > > if (!cl || !buf)
> > > return CMDLINE_PARSE_BAD_ARGS;
> > >
> > > + memset(tmp_result.buf, 0, sizeof(tmp_result.buf));
> > > +
> > > ctx = cl->ctx;
> > >
> > > /*
> >
> >
> > Did you see an issue (a bug or a crash) without the memset()?
> > Or is it to avoid filling unused fields in the parsed struct?
> Yes, I'm using same struct for some similar commands, have to avoid
> filling unused fields.
>
> >
> > I'm not sure if your patch is enough: cmdline_parse() calls
> > match_inst() for each registered command. If a command partially
> > matches (only the first tokens), the buffer is modified. So the next
> > one will start with a dirty buffer.
> >
> > I suggest to put the memset() in match_inst() instead. Something like
> this:
> >
> > if (resbuf != NULL)
> > memset(resbuf, 0, resbuf_size);
> >
> >
> > It will reset the buffer before using it.
> It was there for performance concern, since the buffer could be tainted,
> I'll upload a new version according to your suggestion, appreciate your
> suggestion.
Rte_flow CLI seems to be relying on modified buffer, add Adrien:
testpmd> flow create 0 ingress pattern eth / ipv4 / udp / vxlan / end actions rss queues 1 2 end level 1 / mark id 0x123456 / end
Caught error type 2 (flow rule (handle)): no valid action
>
> >
> > Olivier
next prev parent reply other threads:[~2017-12-07 15:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 15:54 Xueming Li
2017-12-07 14:48 ` Olivier MATZ
2017-12-07 15:05 ` Xueming(Steven) Li
2017-12-07 15:35 ` Xueming(Steven) Li [this message]
2017-12-07 17:13 ` Adrien Mazarguil
2017-12-08 7:02 ` [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory Xueming Li
2017-12-08 12:27 ` Adrien Mazarguil
2017-12-08 13:51 ` Olivier MATZ
2017-12-08 14:50 ` Xueming(Steven) Li
2017-12-08 15:04 ` Adrien Mazarguil
2017-12-08 15:26 ` Olivier MATZ
2017-12-09 15:39 ` [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory Xueming Li
2017-12-14 15:35 ` Olivier MATZ
2017-12-18 10:51 ` Adrien Mazarguil
2017-12-18 13:44 ` Xueming(Steven) Li
2017-12-26 12:57 ` Xueming(Steven) Li
2018-01-16 12:45 ` Olivier Matz
2018-01-18 4:29 ` Xueming(Steven) Li
2018-01-19 9:07 ` Olivier Matz
2018-01-19 18:18 ` Xueming(Steven) Li
2018-01-19 18:16 ` [dpdk-dev] [PATCH v3] cmdline: fix dynamic tokens parsing Xueming Li
2018-01-22 13:13 ` Olivier Matz
2018-01-25 22:14 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0502MB40795CFEF8A79D18E991BC15AC330@VI1PR0502MB4079.eurprd05.prod.outlook.com \
--to=xuemingl@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).