From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
"Nelio Laranjeiro" <notifications@github.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check
Date: Wed, 18 Apr 2018 11:55:48 +0000 [thread overview]
Message-ID: <VI1PR05MB1678D2ABA89F6E997A46C073ACB60@VI1PR05MB1678.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <38100809.DTC8XynbX7@xps>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, April 18, 2018 6:01 AM
> To: Xueming(Steven) Li <xuemingl@mellanox.com>
> Cc: dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>; Nelio Laranjeiro <notifications@github.com>;
> Wenzhuo Lu <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check
>
> 17/04/2018 16:24, Xueming Li:
> > + /* Check that device supports requested rss hash functions. */
> > + if ((dev_info.flow_type_rss_offloads |
> > + dev_conf->rx_adv_conf.rss_conf.rss_hf) !=
> > + dev_info.flow_type_rss_offloads) {
> > + RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: 0x%lx, valid value: 0x%lx\n",
> > + port_id,
> > + dev_conf->rx_adv_conf.rss_conf.rss_hf,
> > + dev_info.flow_type_rss_offloads);
> > + return -EINVAL;
> > + }
>
> Please use PRIx64 and test 32-bit compilation.
>
> Reminder from this recent post:
>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fml%2Farchives%2Fdev%2F201
> 8-
> February%2F090882.html&data=02%7C01%7Cxuemingl%40mellanox.com%7C5508bc716aac41b932fb08d5a4aeb241%7Ca65
> 2971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636595992591300475&sdata=1hirZ1j7VqCMnrzngZFAuQj42OACfxFUgYgzy
> VQyw%2F4%3D&reserved=0
> "
> Most of the times, using %l is wrong (except when printing a long).
> So next time you write %l, please think "I am probably wrong".
> "
Thanks, got following warning from checkpatch when applying this rule to my other patchset, is it normal?
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#49: FILE: drivers/net/mlx5/mlx5_flow.c:2083:
+ " hash:%" PRIx64 "/%u specs:%hhu(%hu), priority:%hu, type:%d,"
next prev parent reply other threads:[~2018-04-18 11:55 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 7:37 [dpdk-dev] [PATCH] net/mlx5: " Xueming Li
2018-03-19 8:29 ` Nélio Laranjeiro
2018-03-22 10:42 ` Xueming(Steven) Li
2018-03-26 11:39 ` Nélio Laranjeiro
2018-04-02 12:41 ` Xueming(Steven) Li
2018-04-04 7:35 ` Nélio Laranjeiro
2018-04-09 12:10 ` [dpdk-dev] [PATCH v1 1/2] ethdev: " Xueming Li
2018-04-16 22:56 ` Thomas Monjalon
2018-04-17 14:24 ` [dpdk-dev] [PATCH v2 " Xueming Li
2018-04-17 22:00 ` Thomas Monjalon
2018-04-18 11:55 ` Xueming(Steven) Li [this message]
2018-04-18 12:15 ` Thomas Monjalon
2018-04-17 14:24 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: only config supported RSS hash types Xueming Li
2018-04-18 8:11 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add supported hash function check Xueming Li
2018-04-18 8:11 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types Xueming Li
2018-04-18 11:06 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add supported hash function check Xueming Li
2018-04-18 11:06 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types Xueming Li
2018-04-18 13:25 ` Adrien Mazarguil
2018-04-18 13:54 ` Xueming(Steven) Li
2018-04-18 14:16 ` Adrien Mazarguil
2018-04-18 14:26 ` Xueming(Steven) Li
2018-04-18 14:47 ` Adrien Mazarguil
2018-04-18 14:10 ` Xueming(Steven) Li
2018-04-18 14:30 ` Adrien Mazarguil
2018-04-19 15:50 ` Xueming(Steven) Li
2018-04-19 15:48 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add supported hash function check Xueming Li
2018-04-20 8:10 ` Adrien Mazarguil
2018-04-19 15:48 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: new parameter for port config all rss command Xueming Li
2018-04-20 8:10 ` Adrien Mazarguil
2018-04-20 13:06 ` [dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO Xueming Li
2018-04-20 13:48 ` Ferruh Yigit
2018-04-20 14:23 ` Ferruh Yigit
2018-04-20 14:23 ` Xueming(Steven) Li
2018-04-20 13:06 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: testpmd support Tx generic tunnel offloads Xueming Li
2018-04-20 14:29 ` Xueming(Steven) Li
2018-04-20 14:30 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add supported hash function check Xueming Li
2018-04-20 14:35 ` Ferruh Yigit
2018-04-20 14:44 ` Xueming(Steven) Li
2018-04-23 15:20 ` Thomas Monjalon
2018-04-23 16:07 ` Ferruh Yigit
2018-04-23 16:06 ` Ferruh Yigit
2018-04-23 18:14 ` Thomas Monjalon
2018-05-01 11:04 ` Ferruh Yigit
2018-05-01 14:04 ` Thomas Monjalon
2018-04-20 14:30 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: new parameter for port config all rss command Xueming Li
2018-04-09 12:10 ` [dpdk-dev] [PATCH v1 2/2] app/testpmd: config all supported RSS functions Xueming Li
2018-04-16 22:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB1678D2ABA89F6E997A46C073ACB60@VI1PR05MB1678.eurprd05.prod.outlook.com \
--to=xuemingl@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=notifications@github.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).