From: Shahaf Shuler <shahafs@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix reception of multiple mac addresses
Date: Thu, 25 Jan 2018 16:00:10 +0000 [thread overview]
Message-ID: <VI1PR05MB314954A3CDD470EAAD2D132BC3E10@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <8d4931d99cd295d8779aefa21900a4e2779e7000.1516868517.git.nelio.laranjeiro@6wind.com>
Thursday, January 25, 2018 10:22 AM, Nelio Laranjeiro:
> Subject: [PATCH] net/mlx5: fix reception of multiple mac addresses
>
> When promiscuous is disabled, adding/removing a mac address is ignored
> causing the packet to not be received or still being received corresponding to
> the add or remove request.
>
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
> index a5e78ec8d..a1cb987cb 100644
> --- a/drivers/net/mlx5/mlx5_mac.c
> +++ b/drivers/net/mlx5/mlx5_mac.c
> @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev,
> uint32_t index) {
> assert(index < MLX5_MAX_MAC_ADDRESSES);
> memset(&dev->data->mac_addrs[index], 0, sizeof(struct
> ether_addr));
> - if (!dev->data->promiscuous && !dev->data->all_multicast)
> + if (!dev->data->promiscuous)
> mlx5_traffic_restart(dev);
> }
>
> @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct
> ether_addr *mac,
> return EADDRINUSE;
> }
> dev->data->mac_addrs[index] = *mac;
> - if (!dev->data->promiscuous && !dev->data->all_multicast)
> + if (!dev->data->promiscuous)
> mlx5_traffic_restart(dev);
> return ret;
> }
> --
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to next-net-mlx, thanks.
> 2.11.0
prev parent reply other threads:[~2018-01-25 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 8:22 Nelio Laranjeiro
2018-01-25 16:00 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB314954A3CDD470EAAD2D132BC3E10@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).