From: Shahaf Shuler <shahafs@mellanox.com>
To: "Yongseok Koh" <yskoh@mellanox.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Shachar Beiser <shacharbe@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation
Date: Thu, 26 Oct 2017 05:48:34 +0000 [thread overview]
Message-ID: <VI1PR05MB314974C1CD639DA51989F53FC3450@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20171025233040.16911-1-yskoh@mellanox.com>
Thursday, October 26, 2017 2:31 AM, Yongseok Koh:
> When "net/mlx5: replace network to host macros" is rebased for v4, changes
> of "net/mlx5: fix calculating TSO inline size" have been reverted.
>
> Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros")
> Cc: stable@dpdk.org
> Cc: Shachar Beiser <shacharbe@mellanox.com>
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index af0a75546..7785ced44 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -558,14 +558,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf
> **pkts, uint16_t pkts_n)
> break;
> max_wqe -= n;
> if (tso) {
> - uint32_t inl =
> - rte_cpu_to_be_32(copy_b |
> - MLX5_INLINE_SEG);
> -
> - pkt_inline_sz =
> -
> MLX5_WQE_DS(tso_header_sz) *
> - MLX5_WQE_DWORD_SIZE;
> -
> + inl = rte_cpu_to_be_32(copy_b |
> +
> MLX5_INLINE_SEG);
> rte_memcpy((void *)raw,
> (void *)&inl, sizeof(inl));
> raw += sizeof(inl);
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> --
> 2.11.0
next prev parent reply other threads:[~2017-10-26 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 23:30 Yongseok Koh
2017-10-26 5:48 ` Shahaf Shuler [this message]
2017-10-26 8:27 ` Nélio Laranjeiro
2017-10-26 22:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB314974C1CD639DA51989F53FC3450@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shacharbe@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).