From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Ophir Munk <ophirmu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Olga Shern" <olgas@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] net/mlx4: fix single port configuration
Date: Sun, 28 Jan 2018 07:22:31 +0000 [thread overview]
Message-ID: <VI1PR05MB31497ABB5B02F7B0DADFC6EEC3E60@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180126164401.GY4256@6wind.com>
Friday, January 26, 2018 6:44 PM, Adrien Mazarguil:
> Hi Ophir,
>
> On Tue, Jan 23, 2018 at 11:32:47PM +0000, Ophir Munk wrote:
> > The number of mlx4 present ports is calculated as follows:
> > conf.ports.present |= (UINT64_C(1) << device_attr.phys_port_cnt) - 1;
> >
> > That is - all ones sequence (due to -1 subtraction) When retrieving
> > the number of ports, 1 must be added in order to obtain the correct
> > number of ports to the power of 2, as follows:
> > uint32_t ports = rte_log2_u32(conf->ports.present + 1); If 1 was not
> > added, in the case of one port, the number of ports would be falsely
> > calculated as 0.
> >
> > Fixes: 82642799 ("net/mlx4: check max number of ports dynamically")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>
> I was too busy to reply earlier, thanks for taking care of this issue.
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to next-net-mlx, thanks.
>
> --
> Adrien Mazarguil
> 6WIND
next prev parent reply other threads:[~2018-01-28 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 23:32 Ophir Munk
2018-01-26 16:44 ` Adrien Mazarguil
2018-01-28 7:22 ` Shahaf Shuler [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-23 23:29 Ophir Munk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB31497ABB5B02F7B0DADFC6EEC3E60@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).