From: Shahaf Shuler <shahafs@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Raslan Darawsheh" <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules
Date: Wed, 6 Dec 2017 06:43:07 +0000 [thread overview]
Message-ID: <VI1PR05MB3149804C01C02B434512E07AC3320@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20171205095639.sebpze34rhlt5jdd@laranjeiro-vm.dev.6wind.com>
Tuesday, December 5, 2017 11:57 AM, Nelio Laranjeiro:
> On Tue, Dec 05, 2017 at 11:37:50AM +0200, Raslan Darawsheh wrote:
> > Chnaged ibv_flow_attr type for allmulti rule to
> > IBV_FLOW_ATTR_MC_DEFAULT instead of IBV_FLOW_ATTR_NORMAL, in
> case allmulti was enabled.
> >
> > Fixes: 272733b5 ("net/mlx5: use flow to enable unicast traffic")
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5_flow.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow.c
> > b/drivers/net/mlx5/mlx5_flow.c index 1eda836..eaa53e2 100644
> > --- a/drivers/net/mlx5/mlx5_flow.c
> > +++ b/drivers/net/mlx5/mlx5_flow.c
> > @@ -429,6 +429,7 @@ static const struct mlx5_flow_items
> > mlx5_flow_items[] = {
> > /** Structure to pass to the conversion function. */ struct
> > mlx5_flow_parse {
> > uint32_t inner; /**< Set once VXLAN is encountered. */
> > + uint8_t allmulti:1; /** Set once allmulti dst MAC is encountered. */
Changed comment to /**< Set once allmulti dst MAC is encountered. */ to fit doxygen style.
> > uint32_t create:1;
> > /**< Whether resources should remain after a validate. */
> > uint32_t drop:1; /**< Target is a drop queue. */ @@ -1165,6
> +1166,17
> > @@ priv_flow_convert(struct priv *priv,
> > }
> > }
> > }
> > + if (parser->allmulti &&
> > + parser->layer == HASH_RXQ_ETH) {
> > + for (i = 0; i != hash_rxq_init_n; ++i) {
> > + if (!parser->queue[i].ibv_attr)
> > + continue;
> > + if (parser->queue[i].ibv_attr->num_of_specs != 1)
> > + break;
> > + parser->queue[i].ibv_attr->type =
> > +
> IBV_FLOW_ATTR_MC_DEFAULT;
> > + }
> > + }
> > return ret;
> > exit_enomem:
> > for (i = 0; i != hash_rxq_init_n; ++i) { @@ -1262,6 +1274,7 @@
> > mlx5_flow_create_eth(const struct rte_flow_item *item,
> > eth.val.ether_type &= eth.mask.ether_type;
> > }
> > mlx5_flow_create_copy(parser, ð, eth_size);
> > + parser->allmulti = eth.val.dst_mac[0] & 1;
> > return 0;
> > }
> >
> > --
> > 2.7.4
>
> It also concerns DPDK 17.11, adding stable@dpdk.org
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to next-net-mlx with the Cc:stable@dpdk.org addition, thanks.
>
> --
> Nélio Laranjeiro
> 6WIND
prev parent reply other threads:[~2017-12-06 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1512466670-19229-1-git-send-email-rasland@mellanox.com>
2017-12-05 9:56 ` Nelio Laranjeiro
2017-12-06 6:43 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149804C01C02B434512E07AC3320@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).