DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	"Adrien Mazarguil" <adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use the RSS table max size from config
Date: Thu, 25 Jan 2018 15:56:34 +0000	[thread overview]
Message-ID: <VI1PR05MB3149997023EE953360505DF7C3E10@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <0a5f6aa5e5801d57ec8c77377d78eeb2b54a4b85.1516868356.git.nelio.laranjeiro@6wind.com>

Thursday, January 25, 2018 10:20 AM, Nelio Laranjeiro:
> Subject: [PATCH] net/mlx5: use the RSS table max size from config
> 
> Maximum indirection table size has not been updated accordingly.
> 
> Fixes: 7fe24446e946 ("net/mlx5: add device configuration structure")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
>  drivers/net/mlx5/mlx5.h     | 1 -
>  drivers/net/mlx5/mlx5_rxq.c | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> a7ec607c3..2602267c3 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -160,7 +160,6 @@ struct priv {
>  	unsigned int txqs_n; /* TX queues array size. */
>  	struct mlx5_rxq_data *(*rxqs)[]; /* RX queues. */
>  	struct mlx5_txq_data *(*txqs)[]; /* TX queues. */
> -	unsigned int ind_table_max_size; /* Maximum indirection table size.
> */
>  	struct rte_eth_rss_conf rss_conf; /* RSS configuration. */
>  	struct rte_intr_handle intr_handle; /* Interrupt handler. */
>  	unsigned int (*reta_idx)[]; /* RETA index table. */ diff --git
> a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index
> 0274ccf31..3c716b960 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1203,7 +1203,7 @@ mlx5_priv_ind_table_ibv_new(struct priv *priv,
> uint16_t queues[],
>  	struct mlx5_ind_table_ibv *ind_tbl;
>  	const unsigned int wq_n = rte_is_power_of_2(queues_n) ?
>  		log2above(queues_n) :
> -		log2above(priv->ind_table_max_size);
> +		log2above(priv->config.ind_table_max_size);
>  	struct ibv_wq *wq[1 << wq_n];
>  	unsigned int i;
>  	unsigned int j;

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Merged to next-net-mlx, thanks. 

> --
> 2.11.0

      reply	other threads:[~2018-01-25 15:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  8:19 Nelio Laranjeiro
2018-01-25 15:56 ` Shahaf Shuler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR05MB3149997023EE953360505DF7C3E10@VI1PR05MB3149.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).