From: Shahaf Shuler <shahafs@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Harish Patil <harish.patil@cavium.com>,
"Dept-EngDPDKDev@cavium.com" <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO
Date: Tue, 5 Dec 2017 06:05:49 +0000 [thread overview]
Message-ID: <VI1PR05MB3149A4353F5EF8F55FEB8BFBC33D0@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <86c2d0ce-c1fc-a4c0-6fe7-e8f34c3ccb03@intel.com>
Tuesday, December 5, 2017 1:25 AM, Ferruh Yigit:
> On 11/24/2017 12:35 PM, Rasesh Mody wrote:
> > From: Harish Patil <harish.patil@cavium.com>
> >
> > Add an optional cmdline parameter to enable LRO. This is useful to
> > test LRO feature by being able to run linux utils like iperf over KNI
> > interface which generates consistent packet aggregations.
> >
> > Signed-off-by: Harish Patil <harish.patil@cavium.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> I think this patch has no dependency for rest of the patchset and can be
> separately applied.
Snipped from the patch [1]
Please use the new ethdev offloads API. there is already a series to convert the examples including kni[2], I think it is better to work on top of it.
[1]
@@ -611,6 +618,10 @@ struct kni_interface_stats {
/* Initialise device and RX/TX queues */
RTE_LOG(INFO, APP, "Initialising port %u ...\n", (unsigned)port);
fflush(stdout);
+
+ if (enable_lro)
+ port_conf.rxmode.enable_lro = 1;
+
[2] http://dpdk.org/dev/patchwork/patch/31558/
next prev parent reply other threads:[~2017-12-05 6:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 20:35 [dpdk-dev] [PATCH 0/5] net/qede: add enhancements and fixes Rasesh Mody
2017-11-24 20:35 ` [dpdk-dev] [PATCH 1/5] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-11-24 20:35 ` [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO Rasesh Mody
2017-12-04 23:25 ` Ferruh Yigit
2017-12-05 6:05 ` Shahaf Shuler [this message]
2017-12-05 19:43 ` Patil, Harish
2017-12-05 19:42 ` Patil, Harish
2017-11-24 20:35 ` [dpdk-dev] [PATCH 3/5] net/qede: fix to reject config with no Rx queue Rasesh Mody
2017-11-24 20:35 ` [dpdk-dev] [PATCH 4/5] app/testpmd: add configuration for udp port tunnel type Rasesh Mody
2017-12-07 0:38 ` Ferruh Yigit
2017-12-07 18:18 ` Shaikh, Shahed
2017-11-24 20:35 ` [dpdk-dev] [PATCH 5/5] net/qede: add support for GENEVE tunneling offload Rasesh Mody
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 0/3] net/qede: add enhancements and fixes Rasesh Mody
2017-12-15 21:05 ` Ferruh Yigit
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue Rasesh Mody
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 3/3] net/qede: add support for GENEVE tunneling offload Rasesh Mody
2017-12-15 21:01 ` Ferruh Yigit
2017-12-15 21:12 ` Mody, Rasesh
2017-12-16 0:19 ` Ferruh Yigit
2017-12-16 0:42 ` Mody, Rasesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149A4353F5EF8F55FEB8BFBC33D0@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harish.patil@cavium.com \
--cc=rasesh.mody@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).