From: Shahaf Shuler <shahafs@mellanox.com>
To: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags
Date: Wed, 13 Dec 2017 07:25:10 +0000 [thread overview]
Message-ID: <VI1PR05MB3149A902C0461B493DCF41E7C3350@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <82d7dce3-91a3-9965-b798-78013af70a3d@caviumnetworks.com>
>> We can do it. yes.
>+1 for Ferruh. --txqflags argument was very handy in testing features in batch mode. Let us have something equivalent.
It is there. Checkout v2 of the series, an equivalent parameter was added: tx-offloads.
--Shahaf
From: Maciej Czekaj [mailto:maciej.czekaj@caviumnetworks.com]
Sent: Tuesday, December 12, 2017 2:45 PM
To: Shahaf Shuler <shahafs@mellanox.com>; Ferruh Yigit <ferruh.yigit@intel.com>; jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags
-- Oryginal message --
Thursday, December 7, 2017 1:05 AM, Ferruh Yigit:
On 12/4/2017 10:48 PM, Shahaf Shuler wrote:
Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit:
On 11/23/2017 4:08 AM, Shahaf Shuler wrote:
Since testpmd is now using the new Ethdev offloads API there is no
need for the txqflags configuration.
txqflag command-line option (--txqflags=0xXXXXXXXX) and command
(port
config all txqflags value) are way to dynamically provide Tx offload
configuration to testpmd.
Why you are removing them without providing equivalent feature with
new offload APIs?
There is one, and this is why the new offloads API simplifies applications
life.
The txq_flags were introduced so application can disable some of the Tx
offloads from the time the Tx offloads were set by default.
Now the Tx offloads are all disabled by default. And there is an option to
set each one of the using DEV_TX_OFFLOAD_* flags.
Look on the Rx side (there the Rx offloads were disabled by default in the
old API). there is no rxq_flags.
I mean providing a testpmd command and command-line option.
Or am I missing it, after this update is there a way to update enabled Tx
offloads in testpmd via command and command-line?
There is a way to update via CLI
For example when doing "tso set <mss> <port>" the DEV_TX_OFFLOAD_TSO will be set
When doing tx_vlan add <port> <vlan> the DEV_TX_OFFLOAD_VLAN_INSERT will be set
Same for every Tx offloads besides DEV_TX_OFFLOAD_MULTI_SEGS and DEV_TX_OFFLOAD_MBUF_FAST_FREE which I added on separate patches.
But to make it precise you didn’t had before (with the txq_flags) a way to disable TSO from the command line (the is no TXQ flag for that) nor the tunnel TSO.
Patch 3/4 & 4/5 adds new command-line options to enable some of
recently introduced Tx offloads in testpmd, why not add a generic way
to update all Tx offloads instead of those two specific offloads?
Because those 2 new offloads were missing a way to set in testpmd.
The rest of the offloads can be set using the CLI commands exists today.
Am not sure we want every Tx offloads to be set from both CLI and
command line arguments.
It wasn't before (for example there was no --disable-tso flags).
I was thinking a generic command-line instead of introducing one for all,
overall single variable represents all offload values, why not set it at once, as
--txqflags you are removing in this patch.
We can do it. yes.
+1 for Ferruh. --txqflags argument was very handy in testing features in batch mode. Let us have something equivalent.
Also this patch removing ability to display current Tx offload
configuration....
Can you point where ?
I mean following:
- printf(" TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n",
- tx_conf->tx_rs_thresh, tx_conf->txq_flags);
+ printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);
Why not an offloads replacement of this one?
Will be added.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com><mailto:shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com><mailto:nelio.laranjeiro@6wind.com>
<...>
next prev parent reply other threads:[~2017-12-13 7:25 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 12:07 [dpdk-dev] [PATCH 0/5] convert testpmd to new ethdev offloads API Shahaf Shuler
2017-11-23 12:08 ` [dpdk-dev] [PATCH 1/5] app/testpmd: convert to new Ethdev " Shahaf Shuler
2017-12-04 22:31 ` Ferruh Yigit
2017-12-05 6:39 ` Shahaf Shuler
2017-12-06 22:57 ` Ferruh Yigit
2017-12-07 7:55 ` Shahaf Shuler
2017-11-23 12:08 ` [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags Shahaf Shuler
2017-12-04 22:31 ` Ferruh Yigit
2017-12-05 6:48 ` Shahaf Shuler
2017-12-06 23:04 ` Ferruh Yigit
2017-12-07 7:56 ` Shahaf Shuler
2017-12-12 12:45 ` Maciej Czekaj
2017-12-13 7:25 ` Shahaf Shuler [this message]
2017-11-23 12:08 ` [dpdk-dev] [PATCH 3/5] app/testpmd: add command line option for multiseg Shahaf Shuler
2017-11-23 12:08 ` [dpdk-dev] [PATCH 4/5] app/testpmd: add command line option for mbuf fast free Shahaf Shuler
2017-11-23 12:08 ` [dpdk-dev] [PATCH 5/5] app/testpmd: enforce offloads caps Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 00/10] convert testpmd to new ethdev offloads API Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 01/10] app/testpmd: fix port configuration print Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 02/10] app/testpmd: convert to new Ethdev Rx offloads API Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 03/10] app/testpmd: support check of single port stop Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 04/10] app/testpmd: convert to new Ethdev Tx offloads API Shahaf Shuler
2018-01-05 18:11 ` Maciej Czekaj
2018-01-07 15:24 ` Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 05/10] app/testpmd: fix flowgen forwarding ol flags Shahaf Shuler
2018-01-09 5:32 ` Lu, Wenzhuo
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 06/10] app/testpmd: cleanup internal Tx offloads flags field Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 07/10] app/testpmd: add command line option for Tx offloads Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 08/10] app/testpmd: remove txqflags Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 09/10] app/testpmd: enforce offloads caps Shahaf Shuler
2017-12-12 12:52 ` [dpdk-dev] [PATCH v2 10/10] app/testpmd: fix on the flight VLAN configuration Shahaf Shuler
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 00/10] convert testpmd to new ethdev offloads API Shahaf Shuler
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 01/10] app/testpmd: fix port configuration print Shahaf Shuler
2018-01-05 3:33 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 02/10] app/testpmd: convert to new Ethdev Rx offloads API Shahaf Shuler
2018-01-09 3:05 ` Lu, Wenzhuo
2018-01-19 19:30 ` Patil, Harish
2018-01-20 19:29 ` Shahaf Shuler
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 03/10] app/testpmd: support check of single port stop Shahaf Shuler
2018-01-09 3:20 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API Shahaf Shuler
2018-01-09 5:27 ` Lu, Wenzhuo
2018-01-09 6:47 ` Shahaf Shuler
2018-01-09 7:13 ` Lu, Wenzhuo
2018-01-09 10:02 ` Shahaf Shuler
2018-01-09 11:37 ` Lu, Wenzhuo
2018-01-09 12:14 ` Ananyev, Konstantin
2018-01-10 0:37 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 05/10] app/testpmd: fix flowgen forwarding ol flags Shahaf Shuler
2018-01-09 5:35 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx offloads flags field Shahaf Shuler
2018-01-09 6:30 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 07/10] app/testpmd: add command line option for Tx offloads Shahaf Shuler
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags Shahaf Shuler
2018-01-09 7:17 ` Lu, Wenzhuo
2018-01-09 10:07 ` Shahaf Shuler
2018-01-09 11:51 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 09/10] app/testpmd: enforce offloads caps Shahaf Shuler
2018-01-09 7:48 ` Lu, Wenzhuo
2017-12-26 9:44 ` [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration Shahaf Shuler
2018-01-09 8:05 ` Lu, Wenzhuo
2018-01-09 10:03 ` Shahaf Shuler
2018-01-09 11:44 ` Lu, Wenzhuo
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 00/11] convert testpmd to new ethdev offloads API Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 01/11] app/testpmd: fix port configuration print Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 02/11] app/testpmd: convert to new Ethdev Rx offloads API Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 03/11] app/testpmd: support check of single port stop Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 04/11] app/testpmd: convert to new Ethdev Tx offloads API Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 05/11] app/testpmd: fix flowgen forwarding ol flags Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 06/11] app/testpmd: cleanup internal Tx offloads flags field Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 07/11] app/testpmd: add command line option for Tx offloads Shahaf Shuler
2018-01-15 3:06 ` Lu, Wenzhuo
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 08/11] app/testpmd: remove txqflags Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 09/11] app/testpmd: enforce offloads caps Shahaf Shuler
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 10/11] app/testpmd: adjust on the flight VLAN configuration Shahaf Shuler
2018-01-15 3:30 ` Lu, Wenzhuo
2018-01-10 9:09 ` [dpdk-dev] [PATCH v4 11/11] app/testpmd: enable fast free Tx offload by default Shahaf Shuler
2018-01-15 3:33 ` Lu, Wenzhuo
2018-01-15 10:00 ` [dpdk-dev] [PATCH v4 00/11] convert testpmd to new ethdev offloads API Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149A902C0461B493DCF41E7C3350@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=maciej.czekaj@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).