From: Shahaf Shuler <shahafs@mellanox.com>
To: Jiayu Hu <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"lei.a.yao@intel.com" <lei.a.yao@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation
Date: Thu, 25 Jan 2018 06:54:22 +0000 [thread overview]
Message-ID: <VI1PR05MB3149C2ADA54FF3A77BFADA0AC3E10@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1516846424-19929-1-git-send-email-jiayu.hu@intel.com>
Hi Jiayu Hu,
Good fix, thanks.
Thursday, January 25, 2018 4:14 AM, Jiayu Hu:
> In current design, we can't enable SW checksum calculation for the devices
> which don't have checksum offloading abilities via the command "csum set
> ip|tcp|udp|sctp|outer-ip sw <port_id>".
> But SW checksum calculation shouldn't depend on HW offloading abilities.
> This patch is to fix this issue.
>
> Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
> app/test-pmd/cmdline.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 9f12c0f..a2db9b7 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3706,40 +3706,40 @@ cmd_csum_parsed(void *parsed_result,
> hw = 1;
>
> if (!strcmp(res->proto, "ip")) {
> - if (dev_info.tx_offload_capa &
> -
> DEV_TX_OFFLOAD_IPV4_CKSUM) {
> + if (hw == 0 || (dev_info.tx_offload_capa &
> +
> DEV_TX_OFFLOAD_IPV4_CKSUM)) {
> csum_offloads |=
> DEV_TX_OFFLOAD_IPV4_CKSUM;
> } else {
> printf("IP checksum offload is not supported
> "
> "by port %u\n", res->port_id);
> }
> } else if (!strcmp(res->proto, "udp")) {
> - if (dev_info.tx_offload_capa &
> -
> DEV_TX_OFFLOAD_UDP_CKSUM) {
> + if (hw == 0 || (dev_info.tx_offload_capa &
> +
> DEV_TX_OFFLOAD_UDP_CKSUM)) {
> csum_offloads |=
> DEV_TX_OFFLOAD_UDP_CKSUM;
> } else {
> printf("UDP checksum offload is not
> supported "
> "by port %u\n", res->port_id);
> }
> } else if (!strcmp(res->proto, "tcp")) {
> - if (dev_info.tx_offload_capa &
> -
> DEV_TX_OFFLOAD_TCP_CKSUM) {
> + if (hw == 0 || (dev_info.tx_offload_capa &
> +
> DEV_TX_OFFLOAD_TCP_CKSUM)) {
> csum_offloads |=
> DEV_TX_OFFLOAD_TCP_CKSUM;
> } else {
> printf("TCP checksum offload is not
> supported "
> "by port %u\n", res->port_id);
> }
> } else if (!strcmp(res->proto, "sctp")) {
> - if (dev_info.tx_offload_capa &
> -
> DEV_TX_OFFLOAD_SCTP_CKSUM) {
> + if (hw == 0 || (dev_info.tx_offload_capa &
> +
> DEV_TX_OFFLOAD_SCTP_CKSUM)) {
> csum_offloads |=
> DEV_TX_OFFLOAD_SCTP_CKSUM;
> } else {
> printf("SCTP checksum offload is not
> supported "
> "by port %u\n", res->port_id);
> }
> } else if (!strcmp(res->proto, "outer-ip")) {
> - if (dev_info.tx_offload_capa &
> -
> DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) {
> + if (hw == 0 || (dev_info.tx_offload_capa &
> +
> DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM)) {
> csum_offloads |=
>
> DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
> } else {
Reviewed-by: Shahaf Shuler <shahafs@mellanox.com>
> --
> 2.7.4
next prev parent reply other threads:[~2018-01-25 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 2:13 Jiayu Hu
2018-01-25 2:58 ` Lu, Wenzhuo
2018-01-25 3:04 ` Hu, Jiayu
2018-01-25 3:06 ` Hu, Jiayu
2018-01-25 6:54 ` Shahaf Shuler [this message]
2018-01-31 22:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149C2ADA54FF3A77BFADA0AC3E10@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=lei.a.yao@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).