From: Shahaf Shuler <shahafs@mellanox.com>
To: Yanglong Wu <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail
Date: Mon, 5 Feb 2018 06:14:14 +0000 [thread overview]
Message-ID: <VI1PR05MB3149CC2B4B1E2E773B85D165C3FE0@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180205023357.104418-1-yanglong.wu@intel.com>
Hi Wu,
Few small comment.
Monday, February 5, 2018 4:34 AM, Yanglong Wu:
> Subject: [PATCH v2] app/testpmd:vlan filter fail
The commit title can better describe the patch, something like: "app/testpmd: fix port DCB configuration"
>
> This bug is caused by miss port configuration.
The above line is not needed.
> The port_conf for the DCB configuration should inherit the same
> configuration of the port.
>
> Fix:0074d02fc(convert to new Rx offloads API)
It needs to be :
Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v2:
> changing patch accoding to the review
> ---
> app/test-pmd/testpmd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 5dc8ccac5..da1d9bd3a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid,
> /* Enter DCB configuration status */
> dcb_config = 1;
>
> + port_conf.rxmode = rte_port->dev_conf.rxmode;
> + port_conf.txmode = rte_port->dev_conf.txmode;
> +
> /*set configuration of DCB in vt mode and DCB in non-vt mode*/
> retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs,
> pfc_en);
> if (retval < 0)
> --
Otherwise - Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> 2.11.0
next prev parent reply other threads:[~2018-02-05 6:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 5:09 [dpdk-dev] [PATCH] " Yanglong Wu
2018-02-04 6:27 ` Shahaf Shuler
2018-02-05 1:51 ` Wu, Yanglong
2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-02-05 6:14 ` Shahaf Shuler [this message]
2018-02-05 7:36 ` Wu, Yanglong
2018-02-05 7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu
2018-02-05 8:00 ` Yang, Zhiyong
2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu
2018-02-05 8:59 ` Shahaf Shuler
2018-02-05 9:47 ` [dpdk-dev] [PATCH v4] " Yanglong Wu
2018-02-05 9:56 ` Yanglong Wu
2018-02-06 15:09 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149CC2B4B1E2E773B85D165C3FE0@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).