From: Shahaf Shuler <shahafs@mellanox.com>
To: "Yongseok Koh" <yskoh@mellanox.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: fix overwriting bit-fields in SW Rx queue
Date: Wed, 10 Jan 2018 15:22:11 +0000 [thread overview]
Message-ID: <VI1PR05MB3149D65ED8F5FF3CEBE1DA1EC3110@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180109173850.17707-1-yskoh@mellanox.com>
Tuesday, January 9, 2018 7:39 PM, Yongseok Koh:
> Bit-fields in mlx5_rxq_data can be changed on the fly by a control plane - e.g.
> rxq->mark. However, vectorized Rx uses a bit-field to mark pending errors.
> Even if one bit is written, consequence is to write the whole integer and this
> can cause a synchronization issue - two entities write to a same block without
> locking. As the pending_err bit is entirely internal use for the datapath, this
> can be replaced with a local variable.
>
> Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
> Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-01-10 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 22:06 [dpdk-stable] [PATCH] " Yongseok Koh
2018-01-09 17:38 ` [dpdk-stable] [PATCH v2] " Yongseok Koh
2018-01-10 15:22 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149D65ED8F5FF3CEBE1DA1EC3110@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).