From: Shahaf Shuler <shahafs@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Yuanhan Liu" <yliu@fridaylinux.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use PCI BDF as the port name
Date: Thu, 25 Jan 2018 15:43:41 +0000 [thread overview]
Message-ID: <VI1PR05MB3149DCDA19A59C5E37091635C3E10@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180123082348.btfz5hbk72aitosk@laranjeiro-vm.dev.6wind.com>
Tuesday, January 23, 2018 10:24 AM, Nélio Laranjeiro:
> Hi Yuanhan,
>
> On Mon, Jan 22, 2018 at 05:30:06PM +0800, Yuanhan Liu wrote:
> > It is suggested to use PCI BDF to identify a port for port addition in
> > OVS-DPDK. While mlx5 has its own naming style: name it by ib dev name.
> > This breaks the typical OVS DPDK use case and brings more puzzle to
> > the end users.
> >
> > To fix it, this patch changes it to use PCI BDF as the name, too.
> > Also, a postfix " port %u" is added, just in case their might be more
> > than 1 port assoicated with a PCI device.
>
> Seems only ixgbe, sfc, szedata2 use it whereas ark, bnxt, mlx4, mlx5, mrvl,
> softnic don't.
>
> Why not addressing all drivers at once?
>
> > Signed-off-by: Yuanhan Liu <yliu@fridaylinux.org>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to next-net-mlx, thanks.
>
> --
> Nélio Laranjeiro
> 6WIND
next prev parent reply other threads:[~2018-01-25 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 9:30 Yuanhan Liu
2018-01-23 8:23 ` Nélio Laranjeiro
2018-01-25 15:43 ` Shahaf Shuler [this message]
2018-03-01 13:59 ` Ferruh Yigit
2018-03-19 10:42 ` [dpdk-dev] [PATCH] net/mlx5: fix ICC compilation Nelio Laranjeiro
2018-03-20 23:16 ` Yongseok Koh
2018-03-21 6:16 ` Shahaf Shuler
2018-03-21 9:53 ` Ferruh Yigit
2018-03-27 13:07 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149DCDA19A59C5E37091635C3E10@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yliu@fridaylinux.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).