From: Ali Alnubani <alialnu@mellanox.com>
To: 'Anatoly Burakov' <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization
Date: Mon, 14 May 2018 17:00:10 +0000 [thread overview]
Message-ID: <VI1PR05MB42694204FD57773407D575C0D79C0@VI1PR05MB4269.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <99dbef2bd2d8652f20b4d349048d018756f09290.1526310468.git.anatoly.burakov@intel.com>
Tested-by: Ali Alnubani <alialnu@mellanox.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
> Sent: Monday, May 14, 2018 6:47 PM
> To: dev@dpdk.org
> Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>; Jingjing Wu
> <jingjing.wu@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
> ferruh.yigit@intel.com
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization
>
> Patch adding configurable locking has reshuffled some init stages, but did not
> put them back in correct order. Fix order of init by moving everything that
> was before arguments parsing into correct places.
>
> Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable")
>
> Reported-by: Thomas Monjalon <thomas@monjalon.net>
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> app/test-pmd/testpmd.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 664c435..6c3b64a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2646,6 +2646,23 @@ main(int argc, char** argv)
> rte_panic("Cannot register log type");
> rte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG);
>
> +#ifdef RTE_LIBRTE_PDUMP
> + /* initialize packet capture framework */
> + rte_pdump_init(NULL);
> +#endif
> +
> + nb_ports = (portid_t) rte_eth_dev_count_avail();
> + if (nb_ports == 0)
> + TESTPMD_LOG(WARNING, "No probed ethernet
> devices\n");
> +
> + /* allocate port structures, and init them */
> + init_port();
> +
> + set_def_fwd_config();
> + if (nb_lcores == 0)
> + rte_panic("Empty set of forwarding logical cores - check the "
> + "core mask supplied in the command
> parameters\n");
> +
> /* Bitrate/latency stats disabled by default */ #ifdef
> RTE_LIBRTE_BITRATE
> bitrate_enabled = 0;
> @@ -2671,23 +2688,6 @@ main(int argc, char** argv)
> strerror(errno));
> }
>
> -#ifdef RTE_LIBRTE_PDUMP
> - /* initialize packet capture framework */
> - rte_pdump_init(NULL);
> -#endif
> -
> - nb_ports = (portid_t) rte_eth_dev_count_avail();
> - if (nb_ports == 0)
> - TESTPMD_LOG(WARNING, "No probed ethernet
> devices\n");
> -
> - /* allocate port structures, and init them */
> - init_port();
> -
> - set_def_fwd_config();
> - if (nb_lcores == 0)
> - rte_panic("Empty set of forwarding logical cores - check the "
> - "core mask supplied in the command
> parameters\n");
> -
> if (tx_first && interactive)
> rte_exit(EXIT_FAILURE, "--tx-first cannot be used on "
> "interactive mode.\n");
> --
> 2.7.4
next prev parent reply other threads:[~2018-05-14 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 15:46 Anatoly Burakov
2018-05-14 17:00 ` Ali Alnubani [this message]
2018-05-14 18:37 ` Thomas Monjalon
2018-05-14 18:16 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB42694204FD57773407D575C0D79C0@VI1PR05MB4269.eurprd05.prod.outlook.com \
--to=alialnu@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).