From: "Jan Mędala" <jan.medala@outlook.com>
To: Marcin Wojtas <mw@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jpalider@gmail.com" <jpalider@gmail.com>,
"netanel@amazon.com" <netanel@amazon.com>,
"evgenys@amazon.com" <evgenys@amazon.com>,
"matua@amazon.com" <matua@amazon.com>,
"gtzalik@amazon.com" <gtzalik@amazon.com>,
"mk@semihalf.com" <mk@semihalf.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled
Date: Mon, 10 Apr 2017 11:05:32 +0000 [thread overview]
Message-ID: <VI1PR0802MB23350A24595CF14E2F88566897010@VI1PR0802MB2335.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1491562138-2178-5-git-send-email-mw@semihalf.com>
I would recommend to check if packet type is IPv4 before processing IPv4 header for DF flag.
This patch can break logic and go to unknown state when mbuf will contain IPv6 packet. I believe that in case of IPv6 pkt the loop should be skipped to next mbuf, if exists.
Best regards,
Jan
prev parent reply other threads:[~2017-04-10 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 10:48 [dpdk-dev] [PATCH 0/4] Ena PMD fixes Marcin Wojtas
2017-04-07 10:48 ` [dpdk-dev] [PATCH 1/4] net/ena: fix incorrect Rx descriptors allocation Marcin Wojtas
2017-04-10 10:10 ` Jakub Palider
2017-04-07 10:48 ` [dpdk-dev] [PATCH 2/4] net/ena: fix delayed cleanup of Rx descriptors Marcin Wojtas
2017-04-10 10:05 ` Jakub Palider
2017-04-07 10:48 ` [dpdk-dev] [PATCH 3/4] net/ena: cleanup if refilling of Rx descriptors fails Marcin Wojtas
2017-04-07 10:48 ` [dpdk-dev] [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled Marcin Wojtas
2017-04-10 11:05 ` Jan Mędala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB23350A24595CF14E2F88566897010@VI1PR0802MB2335.eurprd08.prod.outlook.com \
--to=jan.medala@outlook.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=jpalider@gmail.com \
--cc=matua@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=netanel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).