From: Gavin Hu <Gavin.Hu@arm.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v8 6/6] devtools: expand meson cross compiling coverage
Date: Fri, 15 Jun 2018 09:31:42 +0000 [thread overview]
Message-ID: <VI1PR08MB31677FE1B74AF2C361CC900B8F7C0@VI1PR08MB3167.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20180615082807.GB23520@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
Thanks for your review, new v9 patch set was submitted.
Any more comments are welcome!
Best Regards,
Gavin
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Friday, June 15, 2018 4:28 PM
> To: Gavin Hu <Gavin.Hu@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v8 6/6] devtools: expand meson cross
> compiling coverage
>
> On Fri, Jun 15, 2018 at 04:01:20PM +0800, Gavin Hu wrote:
> > The default test script covers only default host cc compiler, either
> > gcc or clang, the fix is to cover both, gcc and clang. And also the
> > build dirs are changed to *-host-$c, indicating the difference of cc used.
> >
> > Fixes: a55277a788 ("devtools: add test script for meson builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Song Zhu <song.zhu@arm.com>
> > ---
> > devtools/test-meson-builds.sh | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/devtools/test-meson-builds.sh
> > b/devtools/test-meson-builds.sh index 8447c704b..f75ebbdb1 100755
> > --- a/devtools/test-meson-builds.sh
> > +++ b/devtools/test-meson-builds.sh
> > @@ -50,5 +50,15 @@ for f in config/arm/arm*gcc ; do
> > if ! command -v $c >/dev/null 2>&1 ; then
> > continue
> > fi
> > - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f
> > + export CC="ccache gcc"
> > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-gcc \
> > + --cross-file $f
> > + unset CC
> > + # compile the general v8a also for clang to increase coverage
> > + if [ $f = config/arm/arm64_armv8_linuxapp_gcc ] ; then
> > + export CC="ccache clang"
> > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-clang \
> > + --cross-file $f
> > + unset CC
> > + fi
>
> Indentation is different in the new code, spaces vs tabs, perhaps. I'm also not
> sure the "unset CC" is needed, because I think the build function
> automatically unsets it when done.
>
> One other style comment: rather than having an if condition in the loop and
> putting the extra build there, it might be easier just to put the extra call to
> build outside the main loop, since all values are essentially hardcoded in that
> call anyway.
next prev parent reply other threads:[~2018-06-15 9:31 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180614095127.16245-1-git-send-email-gavin.hu@arm.com>
[not found] ` <20180615070811.18686-1-gavin.hu@arm.com>
2018-06-15 7:08 ` [dpdk-stable] [PATCH v7 1/7] mk: fix cross build errors Gavin Hu
2018-06-15 7:08 ` [dpdk-stable] [PATCH v7 3/7] devtools: fix the Exec format error Gavin Hu
2018-06-15 7:08 ` [dpdk-stable] [PATCH v7 4/7] build: fix the meson build warning Gavin Hu
2018-06-15 7:08 ` [dpdk-stable] [PATCH v7 5/7] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-15 7:08 ` [dpdk-stable] [PATCH v7 6/7] build: fix the meson cross compile error Gavin Hu
2018-06-15 7:08 ` [dpdk-stable] [PATCH v7 7/7] devtools: expand meson cross compiling coverage Gavin Hu
[not found] ` <20180615080120.29253-1-gavin.hu@arm.com>
2018-06-15 8:01 ` [dpdk-stable] [PATCH v8 1/6] mk: fix cross build errors Gavin Hu
2018-06-15 8:01 ` [dpdk-stable] [PATCH v8 3/6] build: fix the meson build warning Gavin Hu
2018-06-15 8:01 ` [dpdk-stable] [PATCH v8 4/6] devtools: fix the missing ninja command error on CentOS Gavin Hu
2018-06-15 8:24 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 8:01 ` [dpdk-stable] [PATCH v8 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-15 8:01 ` [dpdk-stable] [PATCH v8 6/6] devtools: expand meson cross compiling coverage Gavin Hu
2018-06-15 8:28 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 9:31 ` Gavin Hu [this message]
[not found] ` <20180615092605.12043-1-gavin.hu@arm.com>
2018-06-15 9:26 ` [dpdk-stable] [PATCH v9 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-15 9:26 ` [dpdk-stable] [PATCH v9 3/6] build: fix the meson build warning Gavin Hu
2018-06-15 9:26 ` [dpdk-stable] [PATCH v9 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-15 9:59 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 9:26 ` [dpdk-stable] [PATCH v9 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-15 9:26 ` [dpdk-stable] [PATCH v9 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-15 10:01 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
[not found] ` <20180615102143.12778-1-gavin.hu@arm.com>
2018-06-15 10:21 ` [dpdk-stable] [PATCH v10 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-15 10:21 ` [dpdk-stable] [PATCH v10 3/6] build: fix the meson build warning Gavin Hu
2018-06-15 10:21 ` [dpdk-stable] [PATCH v10 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-15 13:27 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-15 10:21 ` [dpdk-stable] [PATCH v10 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-15 10:21 ` [dpdk-stable] [PATCH v10 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-15 14:14 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-19 1:44 ` Gavin Hu
[not found] ` <20180619013746.13268-1-gavin.hu@arm.com>
2018-06-19 1:37 ` [dpdk-stable] [PATCH v11 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-19 1:37 ` [dpdk-stable] [PATCH v11 3/6] build: fix the meson build warning Gavin Hu
2018-06-19 1:37 ` [dpdk-stable] [PATCH v11 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-19 10:12 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-19 10:41 ` Gavin Hu
2018-06-19 12:30 ` Bruce Richardson
2018-06-19 23:58 ` Gavin Hu
2018-06-19 1:37 ` [dpdk-stable] [PATCH v11 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-19 1:37 ` [dpdk-stable] [PATCH v11 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-19 10:14 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-06-19 10:15 ` Bruce Richardson
[not found] ` <20180619103657.19186-1-gavin.hu@arm.com>
2018-06-19 10:36 ` [dpdk-stable] [PATCH v12 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-19 10:36 ` [dpdk-stable] [PATCH v12 3/6] build: fix the meson build warning Gavin Hu
2018-06-24 11:05 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2018-06-19 10:36 ` [dpdk-stable] [PATCH v12 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-19 10:36 ` [dpdk-stable] [PATCH v12 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-19 10:36 ` [dpdk-stable] [PATCH v12 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
2018-06-19 12:31 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
[not found] ` <20180625024913.17219-1-gavin.hu@arm.com>
2018-06-25 2:49 ` [dpdk-stable] [PATCH v13 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-25 16:10 ` [dpdk-stable] [dpdk-dev] " Ali Alnubani
2018-06-27 21:00 ` [dpdk-stable] " Thomas Monjalon
2018-06-25 2:49 ` [dpdk-stable] [PATCH v13 3/6] build: fix the meson build warning Gavin Hu
2018-06-25 16:11 ` [dpdk-stable] [dpdk-dev] " Ali Alnubani
2018-06-25 2:49 ` [dpdk-stable] [PATCH v13 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-27 21:13 ` Thomas Monjalon
2018-06-25 2:49 ` [dpdk-stable] [PATCH v13 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-25 2:49 ` [dpdk-stable] [PATCH v13 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
[not found] ` <20180629172738.2121-1-gavin.hu@arm.com>
2018-06-29 17:27 ` [dpdk-stable] [PATCH v14 1/6] mk: fix makefile based cross build errors Gavin Hu
2018-06-29 17:27 ` [dpdk-stable] [PATCH v14 3/6] build: fix the meson build warning Gavin Hu
2018-06-29 17:27 ` [dpdk-stable] [PATCH v14 4/6] devtools: fix the missing ninja command error Gavin Hu
2018-06-29 17:27 ` [dpdk-stable] [PATCH v14 5/6] build: fix the meson cross compile error Gavin Hu
2018-06-29 17:27 ` [dpdk-stable] [PATCH v14 6/6] devtools: expand meson cross compiling test coverage Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB31677FE1B74AF2C361CC900B8F7C0@VI1PR08MB3167.eurprd08.prod.outlook.com \
--to=gavin.hu@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).