From: Olivier Matz <olivier.matz@6wind.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH] net/virtio: add queue and port ID in some logs
Date: Mon, 17 Oct 2022 09:38:41 +0200 [thread overview]
Message-ID: <Y00GgS1i79gPkFUY@platinum> (raw)
In-Reply-To: <SN6PR11MB350407C35883773B26C045CB9C299@SN6PR11MB3504.namprd11.prod.outlook.com>
Hi Chenbo,
On Mon, Oct 17, 2022 at 06:58:59AM +0000, Xia, Chenbo wrote:
> Hi Olivier,
>
> > -----Original Message-----
> > From: Olivier Matz <olivier.matz@6wind.com>
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Subject: [PATCH] net/virtio: add queue and port ID in some logs
> >
> > Add the queue id and/or the port id in some logs, so it is easier to
> > understand what happens.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> > drivers/net/virtio/virtio_ethdev.c | 6 ++++--
> > drivers/net/virtio/virtio_rxtx.c | 3 ++-
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/virtio/virtio_ethdev.c
> > b/drivers/net/virtio/virtio_ethdev.c
> > index 7e07270a8b..44811c299b 100644
> > --- a/drivers/net/virtio/virtio_ethdev.c
> > +++ b/drivers/net/virtio/virtio_ethdev.c
> > @@ -2807,7 +2807,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
> > return -EINVAL;
> > }
> >
> > - PMD_INIT_LOG(DEBUG, "nb_queues=%d", nb_queues);
> > + PMD_INIT_LOG(DEBUG, "nb_queues=%d (port=%d)", nb_queues,
> > + dev->data->port_id);
>
> Better to use %u for all port_id since it's uint16_t
Yes, will do.
I'll update "nb_queues=%d" too by the way.
>
> Thanks,
> Chenbo
>
> >
> > for (i = 0; i < dev->data->nb_rx_queues; i++) {
> > vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> > @@ -2821,7 +2822,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
> > virtqueue_notify(vq);
> > }
> >
> > - PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
> > + PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=%d)",
> > + dev->data->port_id);
> >
> > for (i = 0; i < dev->data->nb_rx_queues; i++) {
> > vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> > diff --git a/drivers/net/virtio/virtio_rxtx.c
> > b/drivers/net/virtio/virtio_rxtx.c
> > index 4795893ec7..f8a9ee5cdb 100644
> > --- a/drivers/net/virtio/virtio_rxtx.c
> > +++ b/drivers/net/virtio/virtio_rxtx.c
> > @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev
> > *dev, uint16_t queue_idx)
> > vq_update_avail_idx(vq);
> > }
> >
> > - PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs);
> > + PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=%d queue=%d)", nbufs,
> > + dev->data->port_id, queue_idx);
> >
> > VIRTQUEUE_DUMP(vq);
> >
> > --
> > 2.30.2
>
next prev parent reply other threads:[~2022-10-17 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 12:22 Olivier Matz
2022-10-06 13:12 ` Maxime Coquelin
2022-10-17 6:58 ` Xia, Chenbo
2022-10-17 7:38 ` Olivier Matz [this message]
2022-10-17 8:00 ` [PATCH v2] " Olivier Matz
2022-10-17 8:19 ` Xia, Chenbo
2022-10-26 9:09 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y00GgS1i79gPkFUY@platinum \
--to=olivier.matz@6wind.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).