From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
ferruh.yigit@intel.com,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] log: register with standardized names
Date: Tue, 11 May 2021 13:24:31 +0100 [thread overview]
Message-ID: <YJp3f2VxBBEj7dZL@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1803102.QjYkUBZ0BM@thomas>
On Tue, May 11, 2021 at 02:10:47PM +0200, Thomas Monjalon wrote:
> 11/05/2021 13:59, Bruce Richardson:
> > On Tue, May 11, 2021 at 12:09:27PM +0200, Thomas Monjalon wrote:
> > > --- a/drivers/meson.build
> > > +++ b/drivers/meson.build
> > > @@ -59,6 +59,11 @@ foreach subpath:subdirs
> > > drivers += driver_path[1]
> > > else
> > > class = subpath
> > > + endif
> > > +
> > > + log_prefix = 'pmd.' + class
> > > +
> > > + if drivers.length() == 0
> > > subdir(class)
> > > endif
> > >
> >
> > Minor nit - rather than splitting the existing block here, I suggest
> > setting log_prefix = '' at the start of the loop, and leaving the existing
> > else as-is. Then after the "subdir(class)" just check if log_prefix ==
> > '' and then set it to the default. I think it might be easier to read that
> > way. [See suggested change below (untested)]
> >
> > /Bruce
> >
> > diff --git a/drivers/meson.build b/drivers/meson.build
> > index 0052247a5..9d518d361 100644
> > --- a/drivers/meson.build
> > +++ b/drivers/meson.build
> > @@ -51,6 +51,7 @@ endif
> > foreach subpath:subdirs
> > drivers = []
> > std_deps = []
> > + log_prefix = ''
> >
> > # subpath can be either "class" or "class/driver"
> > if subpath.contains('/')
> > @@ -62,6 +63,10 @@ foreach subpath:subdirs
> > subdir(class)
> > endif
> >
> > + if log_prefix == '':
> > + log_prefix = 'pmd.' + class
> > + endif
> > +
>
> OK with this change, I'll send a v4.
>
> Nit: please remove useless huge context when replying :)
>
+1 I had planned to - I just forgot to do so before hitting send!
next prev parent reply other threads:[~2021-05-11 12:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:43 [dpdk-dev] [PATCH] log: deduce log type from filename David Marchand
2021-04-09 13:01 ` Bruce Richardson
2021-04-13 15:07 ` David Marchand
2021-04-26 12:51 ` [dpdk-dev] [PATCH v2] log: register with standardized names David Marchand
2021-05-11 10:09 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-05-11 11:15 ` David Marchand
2021-05-11 11:49 ` Bruce Richardson
2021-05-11 12:01 ` Thomas Monjalon
2021-05-11 11:59 ` Bruce Richardson
2021-05-11 12:10 ` Thomas Monjalon
2021-05-11 12:24 ` Bruce Richardson [this message]
2021-05-11 12:38 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2021-05-11 12:52 ` Bruce Richardson
2021-05-11 13:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJp3f2VxBBEj7dZL@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).