From: Bruce Richardson <bruce.richardson@intel.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dev@dpdk.org, lijuan.tu@intel.com, juraj.linkes@pantheon.tech,
ohilyard@iol.unh.edu, david.marchand@redhat.com,
thomas@monjalon.net, jerinj@marvell.com,
kathleen.capella@arm.com, nd@arm.com
Subject: Re: [PATCH 1/2] examples/l3fwd: use single set of variables throughout the code
Date: Wed, 2 Feb 2022 08:49:49 +0000 [thread overview]
Message-ID: <YfpFrbj3MflkjROm@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220202060403.118301-1-honnappa.nagarahalli@arm.com>
On Wed, Feb 02, 2022 at 06:04:02AM +0000, Honnappa Nagarahalli wrote:
> nb_rxd and nb_txd are used in polling mode and event mode of
> operation. nb_rxd and nb_txd are already global. Make them
> visible to all parts of the application.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> DTS test cases require changing the RX and TX queue depths.
> Currently, this is achieved by patching the DPDK code. This patch set
> provides a mechanism to configure the queue depths while launching
> the application. With this change DTS test cases do not need
> to modify the DPDK code.
>
Good change. DTS should not need to be patching DPDK code.
Series-Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> examples/l3fwd/l3fwd.h | 4 ++++
> examples/l3fwd/l3fwd_event.c | 2 --
> examples/l3fwd/main.c | 5 ++---
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
> index 38ca19133c..4ccdb28b4a 100644
> --- a/examples/l3fwd/l3fwd.h
> +++ b/examples/l3fwd/l3fwd.h
> @@ -81,6 +81,10 @@ struct lcore_conf {
>
> extern volatile bool force_quit;
>
> +/* RX and TX queue depths */
> +extern uint16_t nb_rxd;
> +extern uint16_t nb_txd;
> +
> /* ethernet addresses of ports */
> extern uint64_t dest_eth_addr[RTE_MAX_ETHPORTS];
> extern struct rte_ether_addr ports_eth_addr[RTE_MAX_ETHPORTS];
> diff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c
> index dd9eafa9b9..7a401290f8 100644
> --- a/examples/l3fwd/l3fwd_event.c
> +++ b/examples/l3fwd/l3fwd_event.c
> @@ -43,8 +43,6 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf *port_conf)
> {
> struct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc();
> uint16_t nb_ports = rte_eth_dev_count_avail();
> - uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
> - uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
> unsigned int nb_lcores = rte_lcore_count();
> struct rte_eth_conf local_port_conf;
> struct rte_eth_dev_info dev_info;
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index eb68ffc5aa..acd186ab7d 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -53,9 +53,8 @@
>
> #define MAX_LCORE_PARAMS 1024
>
> -/* Static global variables used within this file. */
> -static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
> -static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
> +uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
> +uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
>
> /**< Ports set in promiscuous mode off by default. */
> static int promiscuous_on;
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-02-02 8:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 6:04 Honnappa Nagarahalli
2022-02-02 6:04 ` [PATCH 2/2] examples/l3fwd: make RX and TX queue size configurable Honnappa Nagarahalli
2022-02-08 7:41 ` Ruifeng Wang
2022-02-02 8:49 ` Bruce Richardson [this message]
2022-02-11 0:26 ` [PATCH v2 1/2] examples/l3fwd: use single set of variables throughout the code Honnappa Nagarahalli
2022-02-11 0:26 ` [PATCH v2 2/2] examples/l3fwd: make RX and TX queue size configurable Honnappa Nagarahalli
2022-02-11 0:53 ` Stephen Hemminger
2022-02-11 3:43 ` Honnappa Nagarahalli
2022-02-11 1:01 ` Stephen Hemminger
2022-02-11 3:38 ` Honnappa Nagarahalli
2022-02-23 6:09 ` [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code Honnappa Nagarahalli
2022-02-23 6:09 ` [PATCH v3 2/2] examples/l3fwd: make RX and TX queue size configurable Honnappa Nagarahalli
2022-02-23 6:13 ` [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code Honnappa Nagarahalli
2022-02-23 9:22 ` Kevin Traynor
2022-03-01 1:56 ` Han, YingyaX
2022-03-08 9:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfpFrbj3MflkjROm@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=kathleen.capella@arm.com \
--cc=lijuan.tu@intel.com \
--cc=nd@arm.com \
--cc=ohilyard@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).