DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Weiguo Li <liwg06@foxmail.com>, dev@dpdk.org
Subject: Re: [PATCH v2 06/16] net/netvsc: add define guards to avoid multi-inclusion
Date: Wed, 9 Feb 2022 09:25:08 +0000	[thread overview]
Message-ID: <YgOIdHLYBDxOJVkv@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220208222801.2b0ba9e5@hermes.local>

On Tue, Feb 08, 2022 at 10:28:01PM -0800, Stephen Hemminger wrote:
> On Wed,  9 Feb 2022 11:02:14 +0800
> Weiguo Li <liwg06@foxmail.com> wrote:
> 
> > Supplement define guards to prevent multiple inclusion.
> > 
> > Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> 
> Why bother these are just driver specific includes, not a public API

On the other hand, if this can be cleaned up globally in DPDK, why not also
fix the internal headers?

  reply	other threads:[~2022-02-09  9:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1644374873.git.liwg06@foxmail.com>
2022-02-09  3:02 ` [PATCH v2 01/16] bus/dpaa: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 02/16] event/octeontx: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 03/16] net/cxgbe: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 04/16] net/enetfec: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 05/16] net/i40e: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 06/16] net/netvsc: " Weiguo Li
2022-02-09  6:28   ` Stephen Hemminger
2022-02-09  9:25     ` Bruce Richardson [this message]
2022-02-09  3:02 ` [PATCH v2 07/16] net/qede: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 08/16] net/tap: " Weiguo Li
2022-02-09  6:28   ` Stephen Hemminger
2022-02-09  3:02 ` [PATCH v2 09/16] net/virtio: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 10/16] raw/ifpga/base: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 11/16] kni: " Weiguo Li
2022-02-09  3:02 ` [PATCH v2 12/16] acl: " Weiguo Li
2022-02-09  9:42   ` Ananyev, Konstantin
2022-02-09 10:12     ` Weiguo Li
2022-02-09  3:16 ` [PATCH v2 13/16] eal: " Weiguo Li
2022-02-09  3:16 ` [PATCH v2 14/16] efd: " Weiguo Li
2022-02-09  3:16 ` [PATCH v2 15/16] hash: " Weiguo Li
2022-02-09  3:16 ` [PATCH v2 16/16] pcapng: " Weiguo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgOIdHLYBDxOJVkv@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=liwg06@foxmail.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).