From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Joyce Kong <joyce.kong@arm.com>,
dpdk stable <stable@dpdk.org>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Ola Liljedahl <ola.liljedahl@arm.com>,
Gavin Hu <gavin.hu@arm.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [PATCH v2 1/7] eal: fix header build with C++
Date: Thu, 10 Feb 2022 14:07:57 +0000 [thread overview]
Message-ID: <YgUcPRkrqpP2qQjI@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8y_-pfYqH6cF1ym3fopLOPT3hC7_RO5Jg3hhCpEY_DGVg@mail.gmail.com>
On Thu, Feb 10, 2022 at 01:57:09PM +0100, David Marchand wrote:
> On Thu, Feb 10, 2022 at 1:03 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > C++ files could not include some headers because:
> >
> > * "new" is a keyword in C++, so can't be a variable name
> > * there is no automatic casting to/from void *
> >
> > Fixes: 184104fc6121 ("ticketlock: introduce fair ticket based locking")
> > Fixes: ebaee6409702 ("trace: simplify trace point headers")
>
> rte_strcpy was moved in this commit.
> This is more about:
> Fixes: 032a7e5499a0 ("trace: implement provider payload")
>
Thank you, I missed that even though I did some searching beyond the commit
I referenced, which I suspected was only moving things!
Unfortunately, I didn't see this before I did up a v3 to fix the CI issues.
If necessary I'll do a v4 to correct, once I check there are no other CI
problems.
/Bruce
next prev parent reply other threads:[~2022-02-10 14:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220204174209.440207-1-bruce.richardson@intel.com>
[not found] ` <20220210120257.585822-1-bruce.richardson@intel.com>
2022-02-10 12:02 ` Bruce Richardson
2022-02-10 12:57 ` David Marchand
2022-02-10 14:07 ` Bruce Richardson [this message]
2022-02-10 12:02 ` [PATCH v2 2/7] eventdev: " Bruce Richardson
2022-02-10 12:02 ` [PATCH v2 3/7] graph: fix missing explicit cast for C++ build Bruce Richardson
2022-02-10 12:02 ` [PATCH v2 4/7] ipsec: " Bruce Richardson
2022-02-10 12:42 ` Ananyev, Konstantin
2022-02-10 12:02 ` [PATCH v2 5/7] table: fix missing explicit casts " Bruce Richardson
2022-02-10 12:02 ` [PATCH v2 6/7] vhost: fix incompatible header includes for C++ Bruce Richardson
[not found] ` <20220210140355.586399-1-bruce.richardson@intel.com>
2022-02-10 14:03 ` [PATCH v3 1/7] eal: fix header build with C++ Bruce Richardson
2022-02-10 14:03 ` [PATCH v3 2/7] eventdev: " Bruce Richardson
2022-02-10 14:03 ` [PATCH v3 3/7] graph: fix missing explicit cast for C++ build Bruce Richardson
2022-02-10 14:03 ` [PATCH v3 4/7] ipsec: " Bruce Richardson
2022-02-10 14:03 ` [PATCH v3 5/7] table: fix missing explicit casts " Bruce Richardson
2022-02-10 14:03 ` [PATCH v3 6/7] vhost: fix incompatible header includes for C++ Bruce Richardson
[not found] ` <20220210154239.587185-1-bruce.richardson@intel.com>
2022-02-10 15:42 ` [PATCH v4 1/7] eal: fix header build with C++ Bruce Richardson
2022-02-14 9:30 ` Joyce Kong
2022-02-10 15:42 ` [PATCH v4 2/7] eventdev: " Bruce Richardson
2022-02-10 15:42 ` [PATCH v4 3/7] graph: fix missing explicit cast for C++ build Bruce Richardson
2022-02-10 15:42 ` [PATCH v4 4/7] ipsec: " Bruce Richardson
2022-02-10 15:42 ` [PATCH v4 5/7] table: fix missing explicit casts " Bruce Richardson
2022-02-10 15:42 ` [PATCH v4 6/7] vhost: fix incompatible header includes for C++ Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgUcPRkrqpP2qQjI@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=ola.liljedahl@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).