From: Bruce Richardson <bruce.richardson@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [PATCH v2 0/2] rte_dump_stack: improvements
Date: Mon, 14 Feb 2022 11:51:57 +0000 [thread overview]
Message-ID: <YgpCXc/DGfV2VMJP@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E9B@smartserver.smartshare.dk>
On Mon, Feb 14, 2022 at 12:10:30PM +0100, Morten Brørup wrote:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Saturday, 12 February 2022 19.45
> >
> > This is update to earlier RFC. Add some more comments and changes
> > to have common code for Linux and FreeBSD
> >
> > Stephen Hemminger (2):
> > eal_debug: do not use malloc in rte_dump_stack
> > eal: common rte_dump_stack for both Linux and FreeBSD
> >
> > lib/eal/freebsd/eal_debug.c | 43 ------------------------
> > lib/eal/freebsd/meson.build | 1 -
> > lib/eal/linux/eal_debug.c | 43 ------------------------
> > lib/eal/linux/meson.build | 1 -
> > lib/eal/unix/eal_debug.c | 65 +++++++++++++++++++++++++++++++++++++
> > lib/eal/unix/meson.build | 5 +--
> > 6 files changed, 68 insertions(+), 90 deletions(-)
> > delete mode 100644 lib/eal/freebsd/eal_debug.c
> > delete mode 100644 lib/eal/linux/eal_debug.c
> > create mode 100644 lib/eal/unix/eal_debug.c
> >
> > --
> > 2.34.1
> >
>
> The dladdr() man page mentions that linking with -ldl is required; I assume this is already part of the DPDK EAL build system?
>
Yes, we should be already linking against dl because of the use of dlopen
for loading drivers dynamically.
next prev parent reply other threads:[~2022-02-14 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 1:10 [RFC] eal_debug: do not use malloc in rte_dump_stack Stephen Hemminger
2022-01-29 8:25 ` Morten Brørup
2022-02-12 18:44 ` [PATCH v2 0/2] rte_dump_stack: improvements Stephen Hemminger
2022-02-12 18:44 ` [PATCH v2 1/2] eal_debug: do not use malloc in rte_dump_stack Stephen Hemminger
2022-02-13 11:41 ` Thomas Monjalon
2022-03-17 23:13 ` Stephen Hemminger
2022-02-12 18:44 ` [PATCH v2 2/2] eal: common rte_dump_stack for both Linux and FreeBSD Stephen Hemminger
2022-02-14 11:10 ` [PATCH v2 0/2] rte_dump_stack: improvements Morten Brørup
2022-02-14 11:51 ` Bruce Richardson [this message]
2022-04-07 12:45 ` David Marchand
2022-04-07 23:06 ` Stephen Hemminger
2022-04-14 19:41 ` [PATCH v3] rte_dump_stack: make in async signal safe Stephen Hemminger
2022-04-14 20:19 ` [PATCH v4] " Stephen Hemminger
2022-06-23 7:51 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgpCXc/DGfV2VMJP@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).