From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: remove redundant drivers enabling
Date: Mon, 28 Feb 2022 09:46:25 +0000 [thread overview]
Message-ID: <YhyZ8SLvTWWm7fiD@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220226183651.2165304-1-thomas@monjalon.net>
On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote:
> No need to explicitly enable drivers bus/vdev and mempool/ring.
>
> bus/vdev is always enabled since
> commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
>
> mempool/ring is always enabled since
> commit 81c2337e044d ("build: make ring mempool driver mandatory")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
One comment inline below.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> .ci/linux-build.sh | 2 +-
> devtools/test-meson-builds.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index 67d68535e0..77c0d1976b 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
> OPTS="$OPTS --buildtype=debugoptimized"
> OPTS="$OPTS -Dcheck_includes=true"
> if [ "$MINI" = "true" ]; then
> - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
> + OPTS="$OPTS -Denable_drivers=net/null"
> OPTS="$OPTS -Ddisable_libs=*"
> fi
> meson build --werror $OPTS
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index c07fd16fdc..a653b253cb 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -221,7 +221,7 @@ for c in gcc clang ; do
> done
>
> build build-mini cc skipABI $use_shared -Ddisable_libs=* \
> - -Denable_drivers=bus/vdev,mempool/ring,net/null
> + -Denable_drivers=net/null
Do we even need this enabled for a mini-build. Would disable_drivers=*/*
not work better to truly have a minimal build?
>
> # test compilation with minimal x86 instruction set
> # Set the install path for libraries to "lib" explicitly to prevent problems
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-02-28 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 18:36 Thomas Monjalon
2022-02-28 9:46 ` Bruce Richardson [this message]
2022-02-28 10:17 ` David Marchand
2022-02-28 10:19 ` Bruce Richardson
2022-03-01 10:04 ` [PATCH v2] " Thomas Monjalon
2022-03-01 10:57 ` David Marchand
2022-03-06 9:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhyZ8SLvTWWm7fiD@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).