From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
Peng Zhang <peng.zhang@corigine.com>,
stable@dpdk.org
Subject: Re: [PATCH v1] net/nfp: compose firmware file name with new hwinfo
Date: Wed, 31 Aug 2022 10:17:28 +0200 [thread overview]
Message-ID: <Yw8ZGAaU5/S5DFu6@oden.dyn.berto.se> (raw)
In-Reply-To: <1659426903-11379-1-git-send-email-chaoyong.he@corigine.com>
Hi all,
A gentle ping on this patch.
On 2022-08-02 15:55:03 +0800, Chaoyong He wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
>
> During initialization of the NFP driver, a file name for loading
> application firmware is composed using the NIC's AMDA information and port
> type (count and speed). E.g.: "nic_AMDA0145-1012_2x10.nffw".
>
> In practice there may be many variants for each NIC type, and many of the
> variants relate to assembly components which do not concern the driver and
> application firmware implementation. Yet the current scheme leads to a
> different application firmware file name for each variant, because they
> have different AMDA information.
>
> To reduce proliferation of content-duplicated application firmware images
> or symlinks, the NIC's management firmware will only expose differences
> between variants that need different application firmware via a newly
> introduced hwinfo, "nffw.partno".
>
> Use of the existing hwinfo, "assembly.partno", is maintained in order to
> support for NICs with management firmware that does not expose
> "nffw.partno".
>
> Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/nfp/nfp_ethdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
> index 5cdd34e588..e9d01f4414 100644
> --- a/drivers/net/nfp/nfp_ethdev.c
> +++ b/drivers/net/nfp/nfp_ethdev.c
> @@ -680,7 +680,9 @@ nfp_fw_setup(struct rte_pci_device *dev,
> char card_desc[100];
> int err = 0;
>
> - nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "assembly.partno");
> + nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "nffw.partno");
> + if (nfp_fw_model == NULL)
> + nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "assembly.partno");
>
> if (nfp_fw_model) {
> PMD_DRV_LOG(INFO, "firmware model found: %s", nfp_fw_model);
> --
> 2.27.0
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2022-08-31 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:55 Chaoyong He
2022-08-31 8:17 ` Niklas Söderlund [this message]
2022-08-31 10:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw8ZGAaU5/S5DFu6@oden.dyn.berto.se \
--to=niklas.soderlund@corigine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).