From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerinj@marvell.com>, <skori@marvell.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>,
<david.marchand@redhat.com>, <orika@nvidia.com>
Subject: Re: [PATCH v2 1/1] ethdev: support congestion management
Date: Tue, 27 Sep 2022 16:09:23 +0100 [thread overview]
Message-ID: <YzMSI29hwFbB3go2@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2199859.3ZeAukHxDK@thomas>
On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote:
> 19/09/2022 14:15, skori@marvell.com:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > NIC HW controllers often come with congestion management support on
> > various HW objects such as Rx queue depth or mempool queue depth.
> >
> > Also, it can support various modes of operation such as RED (Random
> > early discard), WRED etc on those HW objects.
> >
> > This patch adds a framework to express such modes(enum rte_cman_mode)
> > and introduce (enum rte_eth_cman_obj) to enumerate the different
> > objects where the modes can operate on.
> [...]
> > doc/guides/nics/features.rst | 12 +++
> > doc/guides/nics/features/default.ini | 1 +
> > lib/eal/include/meson.build | 1 +
> > lib/eal/include/rte_cman.h | 55 ++++++++++
> > lib/ethdev/ethdev_driver.h | 25 +++++
> > lib/ethdev/meson.build | 1 + lib/ethdev/rte_cman.c |
> > 101 ++++++++++++++++++ lib/ethdev/rte_ethdev.h | 151
> > +++++++++++++++++++++++++++ lib/ethdev/version.map | 6
> > ++
>
> I feel EAL is not the right place for CMAN definitions.
>
> After a discussion with Jerin, I understand we could use the same
> definitions in other API classes, not only ethdev. However I think this
> .h file should be better hosted in lib/ethdev/ with its own namespace
> rte_cman. Then other libs could include this rte_cman.h without having a
> strong dependency on ethdev.
>
> Deal?
>
Would rte_net also be an option? Alternatively, is this related to the work
and structures defined in the meter library header, since it seems also
related to congestion management on ingress?
/Bruce
next prev parent reply other threads:[~2022-09-27 15:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 13:15 [dpdk-dev] [RFC PATCH] " jerinj
2022-05-30 19:43 ` Ajit Khaparde
2022-07-13 12:11 ` Jerin Jacob
2022-05-31 1:09 ` Min Hu (Connor)
2022-07-13 12:16 ` Jerin Jacob
2022-05-31 16:09 ` Stephen Hemminger
2022-07-13 12:25 ` Jerin Jacob
2022-07-13 13:03 ` [dpdk-dev] [PATCH v1] " jerinj
2022-09-19 12:15 ` [PATCH v2 1/1] " skori
2022-09-27 14:36 ` Thomas Monjalon
2022-09-27 15:09 ` Bruce Richardson [this message]
2022-09-28 11:14 ` Jerin Jacob
2022-09-28 12:08 ` Thomas Monjalon
2022-09-28 12:23 ` Jerin Jacob
2022-09-28 13:07 ` Olivier Matz
2022-09-28 8:19 ` Andrew Rybchenko
2022-09-28 12:20 ` Jerin Jacob
2022-09-29 9:35 ` [PATCH v3 " skori
2022-10-04 9:02 ` Andrew Rybchenko
2022-10-04 9:04 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMSI29hwFbB3go2@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=jerinj@marvell.com \
--cc=orika@nvidia.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).