From: Olivier Matz <olivier.matz@6wind.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
skori@marvell.com, Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, david.marchand@redhat.com, orika@nvidia.com
Subject: Re: [PATCH v2 1/1] ethdev: support congestion management
Date: Wed, 28 Sep 2022 15:07:46 +0200 [thread overview]
Message-ID: <YzRHInLRTbqqMQxv@platinum> (raw)
In-Reply-To: <CALBAE1NwtBVW2eCOeC7TrEn1fx-UFPowkxQfgJNSos-ov6D0PQ@mail.gmail.com>
On Wed, Sep 28, 2022 at 05:53:06PM +0530, Jerin Jacob wrote:
> On Wed, Sep 28, 2022 at 5:38 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 28/09/2022 13:14, Jerin Jacob:
> > > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson
> > > <bruce.richardson@intel.com> wrote:
> > > >
> > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote:
> > >
> > > > > > ++
> > > > >
> > > > > I feel EAL is not the right place for CMAN definitions.
> > > > >
> > > > > After a discussion with Jerin, I understand we could use the same
> > > > > definitions in other API classes, not only ethdev. However I think this
> > > > > .h file should be better hosted in lib/ethdev/ with its own namespace
> > > > > rte_cman. Then other libs could include this rte_cman.h without having a
> > > > > strong dependency on ethdev.
> > > > >
> > > > > Deal?
> > > > >
> > > > Would rte_net also be an option? Alternatively, is this related to the work
> > >
> > > Looks like the net is a good option. Since it is just a header file
> > > any place would be OK.
> > >
> > > + @Olivier Matz
> > >
> > > Any objections to keeping rte_cman.h to lib/net?
> >
> > lib/net/ is supposed to be standardized packet headers definitions.
>
> Since it had lib/net/net_crc.h, I thought it is OK to keep it in lib/net.
> No strong opinion. I will keep it as lib/ethdev/rte_cman.h then.
lib/ethdev/rte_cman.h looks better to me too.
next prev parent reply other threads:[~2022-09-28 13:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 13:15 [dpdk-dev] [RFC PATCH] " jerinj
2022-05-30 19:43 ` Ajit Khaparde
2022-07-13 12:11 ` Jerin Jacob
2022-05-31 1:09 ` Min Hu (Connor)
2022-07-13 12:16 ` Jerin Jacob
2022-05-31 16:09 ` Stephen Hemminger
2022-07-13 12:25 ` Jerin Jacob
2022-07-13 13:03 ` [dpdk-dev] [PATCH v1] " jerinj
2022-09-19 12:15 ` [PATCH v2 1/1] " skori
2022-09-27 14:36 ` Thomas Monjalon
2022-09-27 15:09 ` Bruce Richardson
2022-09-28 11:14 ` Jerin Jacob
2022-09-28 12:08 ` Thomas Monjalon
2022-09-28 12:23 ` Jerin Jacob
2022-09-28 13:07 ` Olivier Matz [this message]
2022-09-28 8:19 ` Andrew Rybchenko
2022-09-28 12:20 ` Jerin Jacob
2022-09-29 9:35 ` [PATCH v3 " skori
2022-10-04 9:02 ` Andrew Rybchenko
2022-10-04 9:04 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRHInLRTbqqMQxv@platinum \
--to=olivier.matz@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=orika@nvidia.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).