From: Bruce Richardson <bruce.richardson@intel.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>
Subject: Re: [PATCH v2] eal: choose IOVA mode according to compilation flags
Date: Tue, 6 Jun 2023 16:23:11 +0100 [thread overview]
Message-ID: <ZH9PX2sNxumnVHid@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230606151511.978-1-viacheslavo@nvidia.com>
On Tue, Jun 06, 2023 at 06:15:11PM +0300, Viacheslav Ovsiienko wrote:
> The DPDK can be compiled to be run in IOVA VA mode with
> 'enable_iova_as_pa=false' meson option. If there is no
> explicit EAL --iova-mode parameter specified in the command
> line the rte_eal_init() tried to deduce VA or PA mode without
> taking into account the above mentioned compile time option,
> resulting into initialization failure.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> lib/eal/linux/eal.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index ae323cd492..9856ec9d12 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -1081,7 +1081,10 @@ rte_eal_init(int argc, char **argv)
> if (iova_mode == RTE_IOVA_DC) {
> RTE_LOG(DEBUG, EAL, "Buses did not request a specific IOVA mode.\n");
>
> - if (!phys_addrs) {
> + if (!RTE_IOVA_IN_MBUF) {
> + iova_mode = RTE_IOVA_VA;
> + RTE_LOG(DEBUG, EAL, "IOVA as VA mode is forced by build option.\n");
> + } else if (!phys_addrs) {
> /* if we have no access to physical addresses,
> * pick IOVA as VA mode.
> */
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2023-06-06 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 17:19 [PATCH] " Viacheslav Ovsiienko
2023-04-12 19:12 ` Morten Brørup
2023-04-13 9:42 ` Slava Ovsiienko
2023-06-06 15:15 ` [PATCH v2] " Viacheslav Ovsiienko
2023-06-06 15:23 ` Bruce Richardson [this message]
2023-06-07 16:48 ` Thomas Monjalon
2023-06-08 15:45 ` [PATCH v3] " Viacheslav Ovsiienko
2023-06-12 17:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH9PX2sNxumnVHid@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).