From: Olivier Matz <olivier.matz@6wind.com>
To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [PATCH 1/1] app/test: resolve mbuf_test application failure
Date: Wed, 5 Jul 2023 18:12:25 +0200 [thread overview]
Message-ID: <ZKWWMMTVGq8o7Cwv@arsenic.home> (raw)
In-Reply-To: <BN8PR18MB24827E5E026B0A79D17F124BCF409@BN8PR18MB2482.namprd18.prod.outlook.com>
Hi Rakesh,
On Tue, May 23, 2023 at 03:39:53PM +0000, Rakesh Kudurumalla wrote:
> Ping
>
> Regards,
> Rakesh
>
> > -----Original Message-----
> > From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > Sent: Wednesday, April 26, 2023 2:58 PM
> > To: Olivier Matz <olivier.matz@6wind.com>
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> > Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh Kudurumalla
> > <rkudurumalla@marvell.com>
> > Subject: [PATCH 1/1] app/test: resolve mbuf_test application failure
> >
> > when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> > because we are trying to attach extbuf to a cloned buffer to which external
> > mbuf is already attached.This patch fixes the same.
> >
> > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > ---
> > v2: removed gerrit id
> >
> > app/test/test_mbuf.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> > 8d8d3b9386..e2b81db308 100644
> > --- a/app/test/test_mbuf.c
> > +++ b/app/test/test_mbuf.c
> > @@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> > rte_mempool *pktmbuf_pool)
> > GOTO_FAIL("%s: Bad packet length\n", __func__);
> >
> > /* attach the same external buffer to the cloned mbuf */
> > + clone->ol_flags = 0;
> > rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
> > ret_shinfo);
I think we can simply remove the call to rte_pktmbuf_attach_extbuf() because
after the call to rte_pktmbuf_clone(), the mbuf is already attached.
I mean something like this:
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2345,16 +2345,12 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
__func__);
- /* allocate one more mbuf */
+ /* allocate one more mbuf, it is attached to the same external buffer */
clone = rte_pktmbuf_clone(m, pktmbuf_pool);
if (clone == NULL)
GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
if (rte_pktmbuf_pkt_len(clone) != 0)
GOTO_FAIL("%s: Bad packet length\n", __func__);
-
- /* attach the same external buffer to the cloned mbuf */
- rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
- ret_shinfo);
if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
__func__);
Regards,
Olivier
next prev parent reply other threads:[~2023-07-05 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 9:23 Rakesh Kudurumalla
2023-04-26 9:27 ` Rakesh Kudurumalla
2023-05-23 15:39 ` Rakesh Kudurumalla
2023-07-05 16:12 ` Olivier Matz [this message]
2023-07-24 6:27 ` [EXT] " Rakesh Kudurumalla
2023-07-04 4:39 ` [EXT] " Ashwin Sekhar T K
2023-07-26 5:55 ` [PATCH v2 " Rakesh Kudurumalla
2023-10-03 4:20 ` Rakesh Kudurumalla
2023-10-17 13:18 ` Olivier Matz
2023-11-23 6:42 ` [PATCH v3 1/1] app/test: fix external mbuf test when assertions enabled Rakesh Kudurumalla
2024-03-06 17:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKWWMMTVGq8o7Cwv@arsenic.home \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=rkudurumalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).