From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <ci@dpdk.org>, <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v2 2/2] kni: remove deprecated kernel network interface
Date: Fri, 4 Aug 2023 14:25:35 +0100 [thread overview]
Message-ID: <ZMz8T096ecOjvwIo@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zHSxNV5pDnNgvRUn91Fzv=2OMnaARLpKa6yJunQrPunw@mail.gmail.com>
On Fri, Aug 04, 2023 at 03:19:43PM +0200, David Marchand wrote:
> Hello CI people,
>
> On Tue, Aug 1, 2023 at 6:05 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > kernel/linux/kni/Kbuild | 6 -
> > kernel/linux/kni/compat.h | 157 ----
> > kernel/linux/kni/kni_dev.h | 137 ---
> > kernel/linux/kni/kni_fifo.h | 87 --
> > kernel/linux/kni/kni_misc.c | 719 --------------
> > kernel/linux/kni/kni_net.c | 878 ------------------
> > kernel/linux/kni/meson.build | 41 -
> > kernel/linux/meson.build | 2 +-
>
> This is a heads up for KNI removal in the *main* branch.
>
> With this removal, there is no remaining out of tree Linux kernel module
> to compile/test in DPDK sources. This means that jobs (like the one in
> UNH lab that was compile-testing KNI against the latest Linux kernel
> sources) can be disabled.
>
> Important note: this mail does not ask for any change to LTS releases
> testing. If KNI was built and tested with LTS releases, you should
> continue to do so.
>
Given that there are no linux modules left, can we consider changing the
default setting of "enable_kmods" from "no" to "yes". For FreeBSD there are
no in-tree modules that can support DPDK, so the kernel modules for that OS
should always be built. The only reason for it being disabled was Linux,
but that seems unnecessary now.
Alternative: remove the option completely, and always build kernel modules
for FreeBSD (and any for Windows in future). If in future we add in more
Linux modules (which I can't see happening), add in an "enable_linux_kmods"
option instead to control that.
WDYT?
/Bruce
next prev parent reply other threads:[~2023-08-04 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230801160500.67480-1-stephen@networkplumber.org>
[not found] ` <20230801160500.67480-3-stephen@networkplumber.org>
2023-08-04 13:19 ` David Marchand
2023-08-04 13:25 ` Bruce Richardson [this message]
2023-08-07 7:15 ` David Marchand
2023-08-09 14:20 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMz8T096ecOjvwIo@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=chenbo.xia@intel.com \
--cc=ci@dpdk.org \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kirankumark@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).