From: Bruce Richardson <bruce.richardson@intel.com>
To: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
Cc: <dev@dpdk.org>, <ciara.loftus@intel.com>, <qi.z.zhang@intel.com>,
<john.mcnamara@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH] net/af_xdp: pass cflags to appropriate build components
Date: Thu, 21 Sep 2023 11:43:52 +0100 [thread overview]
Message-ID: <ZQweaCdOsdY0Kejo@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230921102923.65738-1-shibin.koikkara.reeny@intel.com>
On Thu, Sep 21, 2023 at 10:29:23AM +0000, Shibin Koikkara Reeny wrote:
> Commit 33d66940e9ba ("build: use C11 standard") enforces
> the C11 standard so some changes need to be made to the
> af_xdp driver meson build to ensure that the appropriate
> cflags are passed when checking if certain functions are
> available in the libbpf/libxdp libraries.
>
> Fixes: 33d66940e9ba ("build: use C11 standard")
Not sure if that is the correct offending commit, or just the commit that
exposes the already-present issue. I'd add the following also to the commit
log:
Fixes: e024c7e838fc ("net/af_xdp: avoid version-based check for shared UMEM")
That fixline would imply a possible backport though, but no issue has been
seen on versions of DPDK not using C11, so I think we skip backporting this
for now. Putting stable@dpdk.org on CC in case the LTS maintainers have
additional input.
For the code fix itself:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
> ---
> drivers/net/af_xdp/meson.build | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
> index 9a8dbb4d49..3319acca65 100644
> --- a/drivers/net/af_xdp/meson.build
> +++ b/drivers/net/af_xdp/meson.build
> @@ -56,17 +56,17 @@ if build
> '''
>
> if cc.has_function('xsk_socket__create_shared', prefix : xsk_check_prefix,
> - dependencies : ext_deps)
> + dependencies : ext_deps, args: cflags)
> cflags += ['-DRTE_NET_AF_XDP_SHARED_UMEM']
> endif
> if cc.has_function('bpf_object__next_program',
> prefix : '#include <bpf/libbpf.h>',
> - dependencies : bpf_dep)
> + dependencies : bpf_dep, args: cflags)
> cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN']
> endif
> if cc.has_function('bpf_xdp_attach',
> prefix : '#include <bpf/libbpf.h>',
> - dependencies : bpf_dep)
> + dependencies : bpf_dep, args: cflags)
> cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH']
> endif
> endif
> --
> 2.25.1
>
next parent reply other threads:[~2023-09-21 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230921102923.65738-1-shibin.koikkara.reeny@intel.com>
2023-09-21 10:43 ` Bruce Richardson [this message]
2023-09-22 9:31 ` [PATCH v2] net/af_xdp: fix cflags to appropriate UMEM feature Shibin Koikkara Reeny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQweaCdOsdY0Kejo@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).