From: Bruce Richardson <bruce.richardson@intel.com>
To: Rahul Gupta <rahulgupt@linux.microsoft.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>,
<sovaradh@linux.microsoft.com>, <okaya@kernel.org>,
<sujithsankar@microsoft.com>, <sowmini.varadhan@microsoft.com>,
<rahulrgupta27@gmail.com>, Rahul Gupta <rahulgupt@microsoft.com>
Subject: Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions
Date: Wed, 8 Nov 2023 11:51:57 +0000 [thread overview]
Message-ID: <ZUt2XVWqEY+W/U5c@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1698949164-20287-1-git-send-email-rahulgupt@linux.microsoft.com>
On Thu, Nov 02, 2023 at 11:19:24AM -0700, Rahul Gupta wrote:
> From: Rahul Gupta <rahulgupt@microsoft.com>
>
> Initialization often requires rte_eal_init + rte_pktmbuf_pool_create
> which can consume a total time of 500-600 ms:
> a) For many devices FLR may take a significant chunk of time
> (200-250 ms in our use-case), this FLR is triggered during device
> probe in rte_eal_init().
> b) rte_pktmbuf_pool_create() can consume upto 300-350 ms for
> applications that require huge memory.
>
> This cost is incurred on each restart (which happens in our use-case
> during binary updates for servicing).
> This patch provides an optimization using pthreads that appplications
> can use and which can save 200-230ms.
>
> In this patch, rte_eal_init() is refactored into two parts-
> a) 1st part is dependent code ie- it’s a perquisite of the FLR and
> mempool creation. So this code needs to be executed before any
> pthreads. Its named as rte_eal_init_setup()
> b) 2nd part of code is independent code ie- it can execute in parallel
> to mempool creation in a pthread. Its named as rte_probe_and_ioctl().
>
> Existing applications require no changes unless they wish to leverage
> the optimization.
>
> If the application wants to use pthread functionality, it should call-
> a) rte_eal_init_setup() then create two or more pthreads-
> b) in one pthread call- rte_probe_and_ioctl(),
> c) second pthread call- rte_pktmbuf_pool_create()
> d) (optional) Other pthreads for any other independent function.
>
> Signed-off-by: Rahul Gupta <rahulgupt@linux.microsoft.com>
Reading the description, this seems an interesting idea, and a good saving.
If I may, I wonder if I can suggest a slight alternative. Rather than
splitting EAL init into two functions like that, how about providing an
"rte_eal_init_async()" function, which does part 1, and then spawns a
thread for part 2, before returning. We can then provide an
rte_eal_init_done() [or eal_init_async_done()] function to allow apps to
resync and check for EAL being done.
The reason for suggesting this is that the naming and purpose of the APIs
may be a little clearer for the end user. Allowing the async init function
to create threads also allows possible future parallelism in the function
itself. For example, we could do probing of the devices themselves in
parallel.
Regards,
/Bruce
next prev parent reply other threads:[~2023-11-08 11:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 18:19 Rahul Gupta
2023-11-02 18:37 ` Stephen Hemminger
2023-11-07 17:33 ` rahul gupta
2023-11-08 13:53 ` Dmitry Kozlyuk
2023-11-08 15:40 ` Thomas Monjalon
2023-11-09 17:26 ` Rahul Gupta
2023-11-09 17:32 ` Bruce Richardson
2023-11-10 17:25 ` Rahul Gupta
2023-11-08 4:38 ` Rahul Gupta
2023-11-08 11:51 ` Bruce Richardson [this message]
2023-11-08 15:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUt2XVWqEY+W/U5c@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=okaya@kernel.org \
--cc=rahulgupt@linux.microsoft.com \
--cc=rahulgupt@microsoft.com \
--cc=rahulrgupta27@gmail.com \
--cc=sovaradh@linux.microsoft.com \
--cc=sowmini.varadhan@microsoft.com \
--cc=sujithsankar@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).