From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Tyler Retzlaff <roretzla@linux.microsoft.com>,
<dmitry.kozliuk@gmail.com>, <stable@dpdk.org>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal/windows: fix mingw build
Date: Wed, 22 Nov 2023 16:41:04 +0000 [thread overview]
Message-ID: <ZV4vIMQrlfOSvEGw@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8ySzePuUhmzvBwfMHtb8BOQz2P6twxNxQ2mMCnvsLF-Pw@mail.gmail.com>
On Wed, Nov 22, 2023 at 05:36:44PM +0100, David Marchand wrote:
> On Wed, Nov 22, 2023 at 5:32 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > When compiling with mingw on Ubuntu 23.10, I get the following compiler
> > error:
> >
> > ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined [-Werror]
> > 77 | #define MEM_REPLACE_PLACEHOLDER 0x00004000
> > |
> > In file included from /usr/share/mingw-w64/include/minwindef.h:163,
> > from /usr/share/mingw-w64/include/windef.h:9,
> > from /usr/share/mingw-w64/include/windows.h:69,
> > from ../../lib/eal/windows/include/rte_windows.h:32,
> > from ../../lib/eal/windows/include/rte_os_shim.h:9,
> > from ../../lib/eal/common/eal_internal_cfg.h:14,
> > from ../../lib/eal/windows/eal_memory.c:11:
> > /usr/share/mingw-w64/include/winnt.h:5710: note: this is the location of the previous definition
> > 5710 | #define MEM_REPLACE_PLACEHOLDER 0x4000
> >
> > and a similar error for MEM_RESERVE_PLACEHOLDER. These errors can be
> > fixed by wrapping the two defines in #ifndef .. #endif blocks.
> >
> > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> > Cc: dmitry.kozliuk@gmail.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Probably a duplicate of
> https://patchwork.dpdk.org/project/dpdk/patch/20231114170529.176665-1-getelson@nvidia.com/
>
Yep, duplicate. I'll reject my patch in patchwork. Hopefully the patch
above will be merged soon to make this issue go away! :-)
/Bruce
prev parent reply other threads:[~2023-11-22 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 16:32 Bruce Richardson
2023-11-22 16:36 ` David Marchand
2023-11-22 16:41 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV4vIMQrlfOSvEGw@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).