From: Bruce Richardson <bruce.richardson@intel.com>
To: "Ye, MingjinX" <mingjinx.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Xu, HailinX" <hailinx.xu@intel.com>
Subject: Re: [PATCH v7] app/test: secondary process passes allow parameters
Date: Fri, 17 Nov 2023 11:17:04 +0000 [thread overview]
Message-ID: <ZVdLsCu17W7cYcA+@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <SN7PR11MB7139D7E4ABD429388C1828E3E5B7A@SN7PR11MB7139.namprd11.prod.outlook.com>
On Fri, Nov 17, 2023 at 10:24:41AM +0000, Ye, MingjinX wrote:
> Hi Richardson,
>
> can you please take a look at this patch.
>
> Thanks,
> Mingjin
>
Hi,
I acked v6. If nothing major has changed in the patch, then the ack can be
kept for v7. If there is something that has changed that you think I should
look at, please include it in the change-log, so I can check it out.
For now, assuming no major changes:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
/Bruce
>
> > -----Original Message-----
> > From: Ye, MingjinX <mingjinx.ye@intel.com>
> > Sent: Tuesday, November 14, 2023 6:28 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Ye, MingjinX
> > <mingjinx.ye@intel.com>; stable@dpdk.org
> > Subject: [PATCH v7] app/test: secondary process passes allow parameters
> >
> > In EAL related test cases, the allow parameters are not passed to the
> > secondary process, resulting in unexpected NICs being loaded.
> >
> > This patch fixes this issue by appending the allow parameters to the
> > secondary process.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > ---
> > v5: Optimized.
> > ---
> > v6: Optimized.
> > ---
> > v7: Fix CI errors.
> > ---
> > app/test/process.h | 46
> > ++++++++++++++++++++++++++++++++++++++++++----
> > 1 file changed, 42 insertions(+), 4 deletions(-)
> >
> > diff --git a/app/test/process.h b/app/test/process.h index
> > af7bc3e0de..06b2f8b192 100644
> > --- a/app/test/process.h
> > +++ b/app/test/process.h
> > @@ -17,6 +17,7 @@
> > #include <dirent.h>
> >
> > #include <rte_string_fns.h> /* strlcpy */
> > +#include <rte_devargs.h>
> >
> > #ifdef RTE_EXEC_ENV_FREEBSD
> > #define self "curproc"
> > @@ -34,6 +35,34 @@ extern uint16_t flag_for_send_pkts; #endif #endif
> >
> > +#define PREFIX_ALLOW "--allow="
> > +
> > +static int
> > +add_parameter_allow(char **argv, int max_capacity) {
> > + struct rte_devargs *devargs;
> > + int count = 0;
> > +
> > + RTE_EAL_DEVARGS_FOREACH(NULL, devargs) {
> > + if (strlen(devargs->name) == 0)
> > + continue;
> > +
> > + if (devargs->data == NULL || strlen(devargs->data) == 0) {
> > + if (asprintf(&argv[count], PREFIX_ALLOW"%s",
> > devargs->name) < 0)
> > + break;
> > + } else {
> > + if (asprintf(&argv[count], PREFIX_ALLOW"%s,%s",
> > + devargs->name, devargs->data) < 0)
> > + break;
> > + }
> > +
> > + if (++count == max_capacity)
> > + break;
> > + }
> > +
> > + return count;
> > +}
> > +
> > /*
> > * launches a second copy of the test process using the given argv
> > parameters,
> > * which should include argv[0] as the process name. To identify in the @@ -
> > 43,8 +72,10 @@ extern uint16_t flag_for_send_pkts; static inline int
> > process_dup(const char *const argv[], int numargs, const char *env_value) {
> > - int num;
> > - char *argv_cpy[numargs + 1];
> > + int num = 0;
> > + char **argv_cpy;
> > + int allow_num;
> > + int argv_num;
> > int i, status;
> > char path[32];
> > #ifdef RTE_LIB_PDUMP
> > @@ -58,11 +89,18 @@ process_dup(const char *const argv[], int numargs,
> > const char *env_value)
> > if (pid < 0)
> > return -1;
> > else if (pid == 0) {
> > + allow_num =
> > rte_devargs_type_count(RTE_DEVTYPE_ALLOWED);
> > + argv_num = numargs + allow_num + 1;
> > + argv_cpy = calloc(argv_num, sizeof(char *));
> > + if (!argv_cpy)
> > + rte_panic("Memory allocation failed\n");
> > +
> > /* make a copy of the arguments to be passed to exec */
> > for (i = 0; i < numargs; i++)
> > argv_cpy[i] = strdup(argv[i]);
> > - argv_cpy[i] = NULL;
> > - num = numargs;
> > + if (allow_num > 0)
> > + num = add_parameter_allow(&argv_cpy[i],
> > allow_num);
> > + num += numargs;
> >
> > #ifdef RTE_EXEC_ENV_LINUX
> > {
> > --
> > 2.25.1
>
next prev parent reply other threads:[~2023-11-17 11:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 9:35 [PATCH] child process synchronization NIC startup parameters Kaisen You
2023-07-06 2:16 ` Yang, Qiming
2023-07-07 1:21 ` You, KaisenX
2023-07-06 19:07 ` Stephen Hemminger
2023-07-14 5:59 ` [PATCH v2] app/test:subprocess synchronization of parameters Kaisen You
2023-07-17 1:47 ` Kaisen You
2023-07-26 2:39 ` Kaisen You
2023-09-25 9:42 ` [PATCH v3] app/test: secondary process passes allow parameters Mingjin Ye
2023-09-25 9:58 ` David Marchand
2023-09-25 10:09 ` Ye, MingjinX
2023-09-25 10:19 ` David Marchand
2023-09-27 3:42 ` [PATCH v4] app/test: append 'allow' parameters to secondary processes Mingjin Ye
2023-10-13 2:47 ` Huang, ZhiminX
2023-11-09 11:13 ` Bruce Richardson
2023-11-10 10:30 ` [PATCH v5] app/test: secondary process passes allow parameters Mingjin Ye
2023-11-10 11:18 ` Bruce Richardson
2023-11-13 10:42 ` [PATCH v6] " Mingjin Ye
2023-11-13 11:11 ` Bruce Richardson
2023-11-14 10:28 ` [PATCH v7] " Mingjin Ye
2023-11-17 10:05 ` Huang, ZhiminX
2023-11-17 10:24 ` Ye, MingjinX
2023-11-17 11:17 ` Bruce Richardson [this message]
2023-11-24 10:28 ` Ye, MingjinX
2024-03-06 13:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVdLsCu17W7cYcA+@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hailinx.xu@intel.com \
--cc=mingjinx.ye@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).