DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Brian Dooley <brian.dooley@intel.com>
Cc: Kai Ji <kai.ji@intel.com>, <dev@dpdk.org>, <gakhil@marvell.com>
Subject: Re: [PATCH v1] common/qat: option to disable asym driver
Date: Thu, 21 Dec 2023 13:19:09 +0000	[thread overview]
Message-ID: <ZYQ7TYDVm4YGggAm@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20231221122302.2834184-1-brian.dooley@intel.com>

On Thu, Dec 21, 2023 at 12:23:02PM +0000, Brian Dooley wrote:
> Currently the QAT sym and asym drivers can only be disabled together
> when building. Add an option to disable the QAT asym driver.
> 
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>

Hi Brian,

Couple of questions that aren't clear to me from this patch:
* why might someone want to do that?
* are there plans to also allow disabling the "sym" part of the driver

This is a non-standard way of disabling part of a driver, so it would need
to be documented somewhere, as it's not going to be discovered otherwise by
users. The disable_driver option is designed to take filesystem paths, and
there isn't a separate path for the asym and sym driver parts.

/Bruce

      reply	other threads:[~2023-12-21 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 12:23 Brian Dooley
2023-12-21 13:19 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYQ7TYDVm4YGggAm@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=brian.dooley@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=kai.ji@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).