From: Bruce Richardson <bruce.richardson@intel.com>
To: 1819846787 <1819846787@qq.com>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
ciara.power <ciara.power@intel.com>
Subject: Re: 回复： [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail
Date: Mon, 22 Jan 2024 09:05:27 +0000 [thread overview]
Message-ID: <Za4v18YCoyw67GZR@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <tencent_C82F1243E94280DFCEDBF14A86051F7F6805@qq.com>
On Sat, Jan 20, 2024 at 12:18:38PM +0800, 1819846787 wrote:
> I have modified my commitlog and resubmitted the patch, but I seem to
> have forgotten to add a [v2] flag to the patch. Do I need to resubmit
> the patch again?
>
It's better if the v2 is added, but it's probably not necessary in this
case. However, I see now you have resubmitted as a v2 anyway, which is
fine. Please mark older versions of the patch as "superceded" in patchwork
(patches.dpdk.org site - you'll need an account created with the email
address used to submit your patches. That will allow you to update the
status of your own patches yourself)
Also, one other tip, when submitting a new version of a previously reviewed
patch, unless there are major changes, you can keep any previously added
acks from reviewers. For your v2, for example, after your signed-off-by you
could have also added the "Acked-by: Ciara Power ... " line.
Hope these tips help in the future! Thanks for the contribution.
/Bruce
> ------------------ ԭʼʼ� ------------------
>
> ����: "David Marchand"<david.marchand@redhat.com>;
> ��ʱ�: 2024119() 11:54
> ռ�: " "<1819846787@qq.com>;
> ��: "dev"<dev@dpdk.org>; "ciara.power"<ciara.power@intel.com>; "Bruce
> Richardson"<bruce.richardson@intel.com>;
> : Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket
> write fail
>
> Hello,
> On Fri, Jan 19, 2024 at 12:40�6�2PM sunshaowei01 <[1]1819846787@qq.com>
> wrote:
> >
> > Telemetry can only create 10 conns by default, each of which is
> processed
> > by a thread.
> >
> > When a thread fails to write using socket, the thread will end
> directly
> > without reducing the total number of conns.
> >
> > This will result in the machine running for a long time, and if there
> are
> > 10 failures, the telemetry will be unavailable
> >
> Thanks for the patch, do you know which commit first triggered the
> issue?
> This is needed so we add a Fixes: tag in the commitlog for backporting
> the fix in stable releases.
> See
> [2]https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-rela
> ted-issues
> > Signed-off-by: sunshaowei01 <[3]1819846787@qq.com>
> We need your full name in the SoB tag.
> Like, for example in my case, it would be David Marchand
> <[4]david.marchand@redhat.com>.
> --
> David Marchand
>
> References
>
> 1. mailto:1819846787@qq.com
> 2. https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related-issues
> 3. mailto:1819846787@qq.com
> 4. mailto:david.marchand@redhat.com
next prev parent reply other threads:[~2024-01-22 9:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 11:40 sunshaowei01
2024-01-19 11:54 ` Bruce Richardson
2024-01-19 15:42 ` Power, Ciara
2024-01-19 15:54 ` David Marchand
2024-01-20 4:18 ` =?gb18030?B?u9i4tKO6IFtQQVRDSF0gbGliL3RlbGVtZXRyeTpmaXggdGVsZW1ldHJ5IGNvbm5zIGxlYWsgaW4gY2FzZSBvZiBzb2NrZXQgd3JpdGUgZmFpbA==?= =?gb18030?B?MTgxOTg0Njc4Nw==?=
2024-01-22 9:05 ` Bruce Richardson [this message]
2024-01-20 8:58 ` [PATCH] [v2]lib/telemetry:fix telemetry conns leak in case of socket write fail Shaowei Sun
2024-01-22 7:39 ` fengchengwen
2024-01-30 1:57 ` [PATCH] [v3]lib/telemetry:fix " Shaowei Sun
2024-02-01 13:14 ` David Marchand
2024-02-01 14:11 ` =?gb18030?B?u9i4tKO6IFtQQVRDSF0gW3YzXWxpYi90ZWxlbWV0cnk6Zml4IHRlbGVtZXRyeSBjb25ucyBsZWFrIGluIGNhc2Ugb2Ygc29ja2V0IHdyaXRlIGZhaWw=?= =?gb18030?B?IFNoYW9XZWkgU3Vu?=
2024-02-01 15:19 ` [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za4v18YCoyw67GZR@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=1819846787@qq.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).