From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Chengwen Feng <fengchengwen@huawei.com>,
Kevin Laatz <kevin.laatz@intel.com>,
"Elena Agostini" <eagostini@nvidia.com>,
Jerin Jacob <jerinj@marvell.com>,
"Kiran Kumar K" <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <zhirun.yan@intel.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Ciara Power <ciara.power@intel.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH] lib: remove duplicate prefix in logs
Date: Wed, 24 Jan 2024 13:26:58 +0000 [thread overview]
Message-ID: <ZbEQIhmWF1F2eHgo@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20240124120450.546364-1-david.marchand@redhat.com>
On Wed, Jan 24, 2024 at 01:04:49PM +0100, David Marchand wrote:
> RTE_LOG() macros prefixe the log messages based on the logtype.
> This results in logs like:
>
> TMTY: TELEMETRY: Attempting socket bind to path '/run/user/...'
> TMTY: TELEMETRY: Socket creation and binding ok
> TMTY: TELEMETRY: Telemetry initialized ok
>
> Remove redundancy in some libraries following their conversion to
> RTE_LOG/RTE_LOG_LINE.
>
> Fixes: 97433132c2ed ("lib: use per line logging in helpers")
> Fixes: 0e21c7c07d62 ("lib: replace logging helpers")
>
> Reported-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/dmadev/rte_dmadev.c | 3 +--
> lib/gpudev/gpudev.c | 3 +--
> lib/graph/graph_private.h | 2 +-
> lib/node/node_private.h | 2 +-
> lib/telemetry/telemetry.c | 4 ++--
> lib/vhost/vhost.h | 6 +++---
> 6 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
> index 5953a77bd6..dbaa14f262 100644
> --- a/lib/dmadev/rte_dmadev.c
> +++ b/lib/dmadev/rte_dmadev.c
> @@ -35,8 +35,7 @@ RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO);
> #define RTE_LOGTYPE_DMA rte_dma_logtype
>
> #define RTE_DMA_LOG(level, ...) \
> - RTE_LOG_LINE(level, DMA, RTE_FMT("dma: " RTE_FMT_HEAD(__VA_ARGS__ ,), \
> - RTE_FMT_TAIL(__VA_ARGS__ ,)))
> + RTE_LOG_LINE(level, DMA, "" __VA_ARGS__)
>
Is it not useful to have the prefix in the log macro itself? That way it's
consistent across all messages.
/Bruce
next prev parent reply other threads:[~2024-01-24 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 12:04 David Marchand
2024-01-24 12:17 ` Morten Brørup
2024-01-25 8:13 ` David Marchand
2024-01-25 8:53 ` Morten Brørup
2024-01-24 13:26 ` Bruce Richardson [this message]
2024-01-24 13:28 ` Bruce Richardson
2024-01-24 14:39 ` Power, Ciara
2024-01-25 3:06 ` fengchengwen
2024-01-25 12:55 ` [PATCH v2] " David Marchand
2024-02-01 8:53 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbEQIhmWF1F2eHgo@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbox@nvidia.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=fengchengwen@huawei.com \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=kirankumark@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).