From: Bruce Richardson <bruce.richardson@intel.com>
To: Julien Meunier <julien.meunier@nokia.com>
Cc: Jing Chen <jing.d.chen@intel.com>,
Jeff Shaw <jeffrey.b.shaw@intel.com>,
Michael Qiu <qiudayu@chinac.com>, <dev@dpdk.org>,
<stable@dpdk.org>
Subject: Re: [PATCH] net/fm10k: fix cleanup during init failure
Date: Thu, 4 Apr 2024 11:30:28 +0100 [thread overview]
Message-ID: <Zg6BRCe67hXgpUng@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <Zg5-aDObFrez-Sd5@bricha3-mobl1.ger.corp.intel.com>
On Thu, Apr 04, 2024 at 11:18:16AM +0100, Bruce Richardson wrote:
> On Wed, Apr 03, 2024 at 01:55:41PM +0200, Julien Meunier wrote:
> > Cleanup was not done on this PMD if a error is seen during the init:
> > - possible memory leak due to a missing free
> > - interrupt handler was not disabled: if an IRQ is received after the
> > init, a SIGSEGV can be seen (private data stored in
> > rte_eth_devices[port_id] is pointing to NULL)
> >
> > Fixes: a6061d9e7075 ("fm10k: register PF driver")
> > Fixes: 4c287332c39a ("fm10k: add PF and VF interrupt handling")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
>
> Changes LGTM
>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
There are CI failures flagged in patchwork, but they appear unrelated to
this patch itself.
Patch applied to dpdk-next-net-intel.
Thanks,
/Bruce
next prev parent reply other threads:[~2024-04-04 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 11:55 Julien Meunier
2024-04-04 10:18 ` Bruce Richardson
2024-04-04 10:30 ` Bruce Richardson [this message]
2024-04-05 14:32 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg6BRCe67hXgpUng@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jeffrey.b.shaw@intel.com \
--cc=jing.d.chen@intel.com \
--cc=julien.meunier@nokia.com \
--cc=qiudayu@chinac.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).