From: Bruce Richardson <bruce.richardson@intel.com>
To: Marek Pazdan <mpazdan@arista.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>
Subject: Re: [PATCH] igc/ixgbe: add get/set link settings interface
Date: Wed, 27 Mar 2024 11:12:18 +0000 [thread overview]
Message-ID: <ZgP_EivKBT4RxPVw@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240326235909.25276-1-mpazdan@arista.com>
On Tue, Mar 26, 2024 at 04:59:07PM -0700, Marek Pazdan wrote:
> There are link settings parameters available from PMD drivers level
> which are currently not exposed to the user via consistent interface.
> When interface is available for system level those information can
> be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/
> ETHTOOL_GLINKSETTINGS). There are use cases where
> physical interface is passthrough to dpdk driver and is not available
> from system level. Information provided by ioctl carries information
> useful for link auto negotiation settings among others.
> Additionally dpdk-testpmd application has been extended to provided
> testing tool for newly implemtented interface functions.
>
> Signed-off-by: Marek Pazdan <mpazdan@arista.com>
> ---
> .mailmap | 1 +
> app/test-pmd/cmdline.c | 9 +
> app/test-pmd/cmdline_settings.c | 516 +++++++++++++++++++++++++++++
> app/test-pmd/cmdline_settings.h | 14 +
> app/test-pmd/meson.build | 1 +
> app/test-pmd/testpmd.h | 1 +
> app/test-pmd/util.c | 10 +
> drivers/net/igc/igc_ethdev.c | 229 ++++++++++++-
> drivers/net/ixgbe/base/ixgbe_phy.h | 7 +
> drivers/net/ixgbe/ixgbe_ethdev.c | 395 ++++++++++++++++++++++
> lib/ethdev/ethdev_driver.h | 33 ++
> lib/ethdev/rte_ethdev.c | 26 ++
> lib/ethdev/rte_ethdev.h | 215 +++++++++++-
> lib/ethdev/version.map | 3 +
> 14 files changed, 1450 insertions(+), 10 deletions(-)
> create mode 100644 app/test-pmd/cmdline_settings.c
> create mode 100644 app/test-pmd/cmdline_settings.h
>
Hi Marek,
it seems this patch is not just for igc and ixgbe drivers, but is adding a
new feature and pair of functions to ethdev, correct? In order to simplify
review, can you please split this patch up into multiple patches based on
component, for example, ethdev hooks, then testpmd calls using those hooks
and finally the individual driver changes to implement the new functions.
Even the driver changes could probably be omitted, if you want, for the
early versions of the patchset, as we'd need to get agreement on the ethdev
APIs before looking at specific implementations in detail.
Thanks for the contribution,
/Bruce
next prev parent reply other threads:[~2024-03-27 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 23:59 Marek Pazdan
2024-03-27 11:12 ` Bruce Richardson [this message]
2024-04-03 13:40 ` [PATCH] lib: " Marek Pazdan
2024-04-03 16:49 ` Tyler Retzlaff
2024-04-04 7:09 ` David Marchand
2024-04-05 0:55 ` Tyler Retzlaff
2024-04-05 0:56 ` Tyler Retzlaff
2024-04-05 8:58 ` David Marchand
2024-04-05 13:05 ` Dodji Seketeli
2024-04-03 13:59 ` Marek Pazdan
2024-04-03 14:48 ` Thomas Monjalon
2024-04-03 14:59 ` Marek Pazdan
2024-04-03 16:13 ` Thomas Monjalon
2024-04-03 17:23 ` Stephen Hemminger
2024-04-03 22:08 ` Marek Pazdan
2024-04-03 23:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgP_EivKBT4RxPVw@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mpazdan@arista.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).