From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Mike Stolarchuk <mike.stolarchuk@bigswitch.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key
Date: Fri, 1 Mar 2019 17:15:27 +0000 [thread overview]
Message-ID: <a0c1a0ca-e928-a463-2cbb-9692f68d11c7@intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC3E7CA@IRSMSX108.ger.corp.intel.com>
On 10/27/2017 4:31 PM, pablo.de.lara.guarch at intel.com (De Lara Guarch, Pablo)
wrote:
>> From: Mike Stolarchuk [mailto:mike.stolarchuk at bigswitch.com]
>> Sent: Friday, October 27, 2017 4:00 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
>> Cc: Thomas Monjalon <thomas at monjalon.net>; Richardson, Bruce
>> <bruce.richardson at intel.com>; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key
>>
>> Pablo,
>>
>> Also, what about the other patch?
>> the use of a static variable in a recursive call? obviously incorrect for a
>> threaded environment ... has that been accepted?
>
> Hi Mike,
>
> Yes, that patch was accepted.
Hi Pablo, Mike,
The patch is remaining from 2017 and sitting on the patchwork without any comment.
I am marking the patchset as rejected, if they are still relevant please send a
new version on top of latest repo.
Sorry for any inconvenience caused.
For reference patches:
https://patches.dpdk.org/patch/27668/
https://patches.dpdk.org/patch/27669/
https://patches.dpdk.org/patch/27670/
https://patches.dpdk.org/patch/27671/
>
> Thanks,
> Pablo
>
>>
>> regards,
>> mts.
>>
>>
>>
>> On Thu, Oct 19, 2017 at 4:10 AM, De Lara Guarch, Pablo
>> <pablo.de.lara.guarch at intel.com> wrote:
>>
>>
>>> -----Original Message-----
>>> From: Thomas Monjalon [mailto:thomas at monjalon.net]
>>> Sent: Tuesday, October 17, 2017 2:59 PM
>>> To: Richardson, Bruce <bruce.richardson at intel.com>; De Lara Guarch,
>>> Pablo <pablo.de.lara.guarch at intel.com>
>>> Cc: dev at dpdk.org; mstolarchuk <mike.stolarchuk at bigswitch.com>
>>> Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key
>>>
>>> 18/08/2017 22:09, mstolarchuk:
>>>> Improves consistency, allows identifcation of use-sites
>>>>
>>>> Signed-off-by: mstolarchuk <mike.stolarchuk at bigswitch.com>
>>>
>>> Any comment on this patch and others from the same author?
>> Hi,
>>
>> Two of the patches submitted are actually the same, although they have a
>> different enumeration.
>> The patches look like they were part of two different patchsets, so it doesn't
>> look right.
>> Also, patch 6/6 is not applicable anymore, as a similar fix was sent
>> previously.
>>
>> Mike, could you send another patchset, that is rebased on top of the latest
>> code?
>>
>> Thanks,
>> Pablo
>
>
prev parent reply other threads:[~2019-03-01 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 20:09 mstolarchuk
2017-10-17 13:59 ` Thomas Monjalon
2017-10-19 8:10 ` De Lara Guarch, Pablo
2017-10-27 15:00 ` Mike Stolarchuk
2017-10-27 15:31 ` De Lara Guarch, Pablo
2019-03-01 17:15 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c1a0ca-e928-a463-2cbb-9692f68d11c7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mike.stolarchuk@bigswitch.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).