From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: <edwin.brossette@6wind.com>, <dev@dpdk.org>
Cc: <olivier.matz@6wind.com>
Subject: Re: [PATCH] net/ixgbevf: fix RSS init for x550 nics
Date: Tue, 27 Feb 2024 17:26:06 +0000 [thread overview]
Message-ID: <a0f3203c-0261-4da7-aac0-9cdcb9ae86e2@intel.com> (raw)
In-Reply-To: <20240215133145.181302-1-edwin.brossette@6wind.com>
On 15/02/2024 13:31, edwin.brossette@6wind.com wrote:
> From: Edwin Brossette <edwin.brossette@6wind.com>
>
> Different Intel nics with the igxbe pmd do not handle RSS in the same
> way when working with virtualization. While some nics like Intel 82599ES
> only have a single RSS table in the device and leave all rss features to
> be handled by the pf, some other nics like x550 let the vf handle RSS
> features. This can lead to different behavior when rss is enabled
> depending on the model of nic used.
>
> In particular, it occurred that ixgbevf_dev_rx_init() do not initiate
> rss parameters at device init, even if the multi-queue mode option is
> set in the device configuration (ie: RTE_ETH_MQ_RX_RSS is set). Note
> that this issue went unnoticed until now, probably because some nics do
> not really have support for RSS in virtualization mode.
>
> Thus, depending on the nic used, we can we find ourselves in a situation
> where RSS is not configured despite being enabled. This will cause
> serious performance issues because the RSS reta will be fully zeroed,
> causing all packets to go only in the first queue and leaving all the
> others empty.
>
> By looking at ixgbe_reta_size_get(), we can see that only X550 nic
> models have a non zero reta size set in vf mode. Thus add a call to
> ixgbe_rss_configure() for these cards in ixgbevf_dev_rx_init() if the
> option to enable RSS is set.
>
> Fixes: f4d1598ee14f ("ixgbevf: support RSS config on x550")
> Signed-off-by: Edwin Brossette <edwin.brossette@6wind.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 537aa2f68de8..0aa968f7e258 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -5873,6 +5873,25 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
> IXGBE_PSRTYPE_RQPL_SHIFT;
> IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype);
>
> + /* Initialize the rss for x550_vf cards if enabled */
> + switch (hw->mac.type) {
> + case ixgbe_mac_X550_vf:
> + case ixgbe_mac_X550EM_x_vf:
> + case ixgbe_mac_X550EM_a_vf:
> + switch (dev->data->dev_conf.rxmode.mq_mode) {
> + case RTE_ETH_MQ_RX_RSS:
> + case RTE_ETH_MQ_RX_DCB_RSS:
> + case RTE_ETH_MQ_RX_VMDQ_RSS:
> + ixgbe_rss_configure(dev);
> + break;
> + default:
> + break;
> + }
> + break;
> + default:
> + break;
> + }
> +
> ixgbe_set_rx_function(dev);
>
> return 0;
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
--
Regards,
Vladimir
next prev parent reply other threads:[~2024-02-27 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 13:12 [ixgbevf] Problem with RSS initial config after device init on X550 nic Edwin Brossette
2024-02-15 13:31 ` [PATCH] net/ixgbevf: fix RSS init for x550 nics edwin.brossette
2024-02-27 17:26 ` Medvedkin, Vladimir [this message]
2024-02-29 11:49 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0f3203c-0261-4da7-aac0-9cdcb9ae86e2@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=dev@dpdk.org \
--cc=edwin.brossette@6wind.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).