From: Akhil Goyal <akhil.goyal@nxp.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"tredaelli@redhat.com" <tredaelli@redhat.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"amr.mokhtar@intel.com" <amr.mokhtar@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] bbdev: add missing experimental tags
Date: Fri, 14 Dec 2018 09:54:01 +0000 [thread overview]
Message-ID: <a12c2d1a-c50f-1c46-8c3a-05de781a934d@nxp.com> (raw)
In-Reply-To: <1543957065-20990-1-git-send-email-david.marchand@redhat.com>
Hi David,
On 12/5/2018 2:27 AM, David Marchand wrote:
> Those two symbols are missing the experimental tag in the library
> header.
> Because of this, a user can try to call this symbol without being aware
> this is an experimental api (neither compilation nor link warning).
>
> Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_bbdev/rte_bbdev_op.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index 83f62c2..c9200b5 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -459,7 +459,7 @@ struct rte_bbdev_op_pool_private {
> * Operation type as string or NULL if op_type is invalid
> *
> */
> -const char*
> +__rte_experimental const char *
> rte_bbdev_op_type_str(enum rte_bbdev_op_type op_type);
>
> /**
> @@ -482,7 +482,7 @@ struct rte_bbdev_op_pool_private {
> * - Pointer to a mempool on success,
> * - NULL pointer on failure.
> */
> -struct rte_mempool *
> +__rte_experimental struct rte_mempool *
> rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
> unsigned int num_elements, unsigned int cache_size,
> int socket_id);
I can see that there are other APIs as well which are not marked as
experimental like rte_bbdev_dec_op_alloc_bulk
rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc.
-Akhil
next prev parent reply other threads:[~2018-12-14 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 20:57 [dpdk-stable] " David Marchand
2018-12-05 12:23 ` Neil Horman
2018-12-05 16:46 ` Mokhtar, Amr
2018-12-14 9:54 ` Akhil Goyal [this message]
2018-12-14 10:00 ` [dpdk-stable] [dpdk-dev] " David Marchand
2018-12-14 12:35 ` Neil Horman
2018-12-14 12:52 ` Mokhtar, Amr
2018-12-18 10:37 ` David Marchand
2018-12-18 10:43 ` Akhil Goyal
2018-12-18 10:48 ` David Marchand
2018-12-19 9:20 ` Mokhtar, Amr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a12c2d1a-c50f-1c46-8c3a-05de781a934d@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=amr.mokhtar@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).