From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jay Rolette <rolette@infinite.io>
Cc: DPDK <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] config: disable KNI ethtool by default
Date: Tue, 17 Jan 2017 19:25:03 +0000 [thread overview]
Message-ID: <a19aa137-22e2-28b1-12ea-44ee99f7cc76@intel.com> (raw)
In-Reply-To: <e2b5443b-5caa-68a5-d14e-39df3e4e45d1@intel.com>
On 1/17/2017 7:00 PM, Ferruh Yigit wrote:
> On 1/17/2017 6:44 PM, Jay Rolette wrote:
>>
>> On Tue, Jan 17, 2017 at 12:01 PM, Ferruh Yigit <ferruh.yigit@intel.com
>> <mailto:ferruh.yigit@intel.com>> wrote:
>>
>> KNI ethtool support (KNI control path) is not commonly used,
>> and it tends to break the build with new version of the Linux kernel.
>>
>> KNI ethtool feature is disabled by default. KNI datapath is not effected
>> from this update.
>>
>> It is possible to enable feature explicitly with config option:
>> "CONFIG_RTE_KNI_KMOD_ETHTOOL=y"
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com
>> <mailto:ferruh.yigit@intel.com>>
>>
>>
>> Is there a test case somewhere to detect when it gets broken or is the
>> intent to let it bit-rot unless someone enables that option and
>> subsequently discovers it broken?
>>
>> I know we don't do this for every config option, but given the fact that
>> this tends to get broken frequently, it seems riskier.
>
> Agree this has risk to be forgotten/badly broken, I am sharing same concern.
>
> But what happening was, even we fix DPDK for latest kernel, after DPDK
> released, DPDK compilation sometimes broken with new coming kernels.
> Since DPDK already released there is way to fix this, and this sometimes
correction: ... there is _no_ way to fix this ...
> hit people who won't use KNI ethtool at all.
>
> KNI ethtool needs to be taken care by its users.
>
>>
>> Jay
>>
>>
>> ---
>> config/common_linuxapp | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/config/common_linuxapp b/config/common_linuxapp
>> index d4c4f0c..2483dfa 100644
>> --- a/config/common_linuxapp
>> +++ b/config/common_linuxapp
>> @@ -38,7 +38,6 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>> CONFIG_RTE_EAL_IGB_UIO=y
>> CONFIG_RTE_EAL_VFIO=y
>> CONFIG_RTE_KNI_KMOD=y
>> -CONFIG_RTE_KNI_KMOD_ETHTOOL=y
>> CONFIG_RTE_LIBRTE_KNI=y
>> CONFIG_RTE_LIBRTE_VHOST=y
>> CONFIG_RTE_LIBRTE_PMD_VHOST=y
>> --
>> 2.9.3
>>
>>
>
prev parent reply other threads:[~2017-01-17 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 18:01 [dpdk-dev] [PATCH 1/2] kni: add config option for KNI ethtool Ferruh Yigit
2017-01-17 18:01 ` [dpdk-dev] [PATCH 2/2] config: disable KNI ethtool by default Ferruh Yigit
2017-01-17 18:35 ` Thomas Monjalon
2017-01-29 21:38 ` Thomas Monjalon
2017-01-17 18:44 ` Jay Rolette
2017-01-17 19:00 ` Ferruh Yigit
2017-01-17 19:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19aa137-22e2-28b1-12ea-44ee99f7cc76@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rolette@infinite.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).