From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Mike Pattrick <mkp@redhat.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: ktraynor@redhat.com, dev@dpdk.org
Subject: Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support
Date: Tue, 6 Jun 2023 22:42:02 +0100 [thread overview]
Message-ID: <a1c6fe62-f448-f89e-9170-39dac9eb9d11@amd.com> (raw)
In-Reply-To: <3825b2b1-c40f-6bdd-4271-7b56c60795ac@amd.com>
On 6/6/2023 10:37 PM, Ferruh Yigit wrote:
> On 6/6/2023 10:12 PM, Mike Pattrick wrote:
>> Previously the noisy neighbour vnf simulation would only operate in io
>> mode, forwarding packets as is. However, this limited the usefulness of
>> noisy neighbour simulation.
>>
>> This feature has now been expanded to supporting mac, macswap, and
>> 5tswap modes. To facilitate adding this support, some new header files
>> were added.
>>
>> Signed-off-by: Mike Pattrick <mkp@redhat.com>
>> ---
>> v2: Reverted changes to random memory lookup
>> v3: Refactored entire patch
>> v4: Implemented recommended formatting changes
>> v5: Corrected copyright statement and formatting changes
>>
>
> Hi Mike,
>
> There are some comments in v4 seems missed, can you please check the
> comments?
>
My bad, v5 looks good, I was looking to wrong places, let me
review/check this version.
next prev parent reply other threads:[~2023-06-06 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 18:55 [PATCH v3] " Mike Pattrick
2023-05-26 15:34 ` Kevin Traynor
2023-05-26 17:32 ` Mike Pattrick
2023-06-01 16:23 ` Kevin Traynor
2023-06-06 14:17 ` Ferruh Yigit
2023-06-02 18:29 ` [PATCH v4] " Mike Pattrick
2023-06-06 14:27 ` Ferruh Yigit
2023-06-06 21:12 ` [PATCH v5] " Mike Pattrick
2023-06-06 21:37 ` Ferruh Yigit
2023-06-06 21:42 ` Ferruh Yigit [this message]
2023-06-06 22:23 ` Ferruh Yigit
2023-06-07 15:42 ` Mike Pattrick
2023-06-08 9:59 ` [PATCH v6] " Mike Pattrick
2023-06-08 10:25 ` Ferruh Yigit
2023-06-08 10:43 ` Mike Pattrick
2023-06-08 11:42 ` Ferruh Yigit
2023-06-08 13:31 ` [PATCH v7] " Mike Pattrick
2023-06-08 14:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1c6fe62-f448-f89e-9170-39dac9eb9d11@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=mkp@redhat.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).