DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: anatoly.burakov@intel.com
Subject: Re: [PATCH] doc/eal: add caveat about spinlocks from non-pinned threads
Date: Sat, 11 Jun 2022 18:41:38 +0200	[thread overview]
Message-ID: <a2265c92-60fb-9869-8a0a-9bf74e52661f@lysator.liu.se> (raw)
In-Reply-To: <20220610152819.38737-1-stephen@networkplumber.org>

On 2022-06-10 17:28, Stephen Hemminger wrote:
> Need to warn users of DPDK spinlocks from non-pinned threads.
> This is similar wording to Linux documentation in pthread_spin_init.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   doc/guides/prog_guide/env_abstraction_layer.rst | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst
> index 5f0748fba1c0..45d3de8d84f6 100644
> --- a/doc/guides/prog_guide/env_abstraction_layer.rst
> +++ b/doc/guides/prog_guide/env_abstraction_layer.rst
> @@ -797,6 +797,16 @@ Known Issues
>   
>     The debug statistics of rte_ring, rte_mempool and rte_timer are not supported in an unregistered non-EAL pthread.
>   
> ++ locking
> +

Isn't this problem more general than locks? The use of any 
non-preemption safe data structures potentially causes such delays. 
Regular DPDK rings for sure. The lock-less stack? The hash library?

Both actual and open-coded spinlocks internal to the APIs are also very 
common.

> +  If a pthread, that is not pinned to an lcore acquires a lock such as a
> +  DPDK based lock (rte_spinlock, rte_rwlock, rte_ticketlock, rte_mcslock)
> +  then there is a possibility of large application delays.

Pinning or not doesn't matter. What matters is if the thread is 
preempted and thus is prevented from making progress for a long time.

> +  The problem is that if a thread is scheduled off the CPU while it holds
> +  a lock, then other threads will waste time spinning on the lock until
> +  the lock holder is once more rescheduled and releases the lock.
> +
> +
>   cgroup control
>   ~~~~~~~~~~~~~~
>   

      parent reply	other threads:[~2022-06-11 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 15:28 Stephen Hemminger
2022-06-10 23:45 ` Tyler Retzlaff
2022-06-10 23:48 ` Tyler Retzlaff
2022-06-11  0:00   ` Stephen Hemminger
2022-06-11  1:55 ` fengchengwen
2022-06-11  3:33   ` Stephen Hemminger
2022-06-11 16:41 ` Mattias Rönnblom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2265c92-60fb-9869-8a0a-9bf74e52661f@lysator.liu.se \
    --to=hofors@lysator.liu.se \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).